From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [x86, msr]: remove code duplication
Date: Mon, 06 Jul 2009 14:31:36 -0700 [thread overview]
Message-ID: <4A526D38.7000803@zytor.com> (raw)
In-Reply-To: <1246890592-12256-1-git-send-email-borislav.petkov@amd.com>
Borislav Petkov wrote:
> -
> - smp_call_function_many(mask, __rdmsr_on_cpu, &rv, 1);
> + smp_call_function_single(this_cpu, msr_func, &rv, 1);
> + smp_call_function_many(mask, msr_func, &rv, 1);
> preempt_enable();
Why are you using smp_call_function_single() to execute something *on
your own CPU*?
-hpa
next prev parent reply other threads:[~2009-07-06 21:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 14:29 [PATCH] [x86, msr]: remove code duplication Borislav Petkov
2009-07-06 21:31 ` H. Peter Anvin [this message]
2009-07-07 10:37 ` Borislav Petkov
2009-07-07 15:56 ` H. Peter Anvin
2009-07-08 11:19 ` [PATCH] [x86, msr]: execute on the correct CPU subset (was: Re: [PATCH] [x86, msr]: remove code duplication) Borislav Petkov
2009-07-16 16:51 ` Borislav Petkov
2009-07-16 17:24 ` [PATCH] [x86, msr]: execute on the correct CPU subset H. Peter Anvin
2009-07-27 20:46 ` H. Peter Anvin
2009-07-28 10:29 ` Borislav Petkov
2009-07-29 16:49 ` Borislav Petkov
2009-07-29 17:30 ` H. Peter Anvin
2009-07-29 18:02 ` Borislav Petkov
2009-07-29 18:05 ` H. Peter Anvin
2009-07-29 18:46 ` Borislav Petkov
2009-07-29 18:50 ` H. Peter Anvin
2009-07-30 9:10 ` [PATCH] x86, msr: " Borislav Petkov
2009-07-30 9:10 ` [PATCH] x86, msr: unify rdmsr_on_cpus/wrmsr_on_cpus Borislav Petkov
2009-09-14 12:55 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A526D38.7000803@zytor.com \
--to=hpa@zytor.com \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.