From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH V1 10/11] ASoC: DaVinci: i2s don't limit rates
Date: Mon, 06 Jul 2009 15:01:54 -0700 [thread overview]
Message-ID: <4A527452.6050304@boundarydevices.com> (raw)
In-Reply-To: <20090705115746.GB5334@sirena.org.uk>
Mark Brown wrote:
> On Sat, Jul 04, 2009 at 07:30:00PM -0700, Troy Kisky wrote:
>> If the codec is master, we support anything
>> that the codec supports.
>
> Hrm, tricky - the rate configuration doesn't depend on what is master so
> this could cause confusion if the codec is slave.
>
>> -#define DAVINCI_I2S_RATES SNDRV_PCM_RATE_8000_96000
>> +#define DAVINCI_I2S_RATES (SNDRV_PCM_RATE_8000_96000 |\
>> + SNDRV_PCM_RATE_5512 | SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS)
>
> Note that the ASoC core doesn't support _KNOT or _CONTINUOUS (at least
> not properly) so the only thing you should get from this is 5512. Is
> that really worth worrying about the master/slave problem?
>
Ok. I'll drop this. I just needed it when I was testing all rates my codec supports.
Now that I've tested it, I don't think I'll ever use the other rates.
But even if the cpu is the clock/frame master, the sample rate generator has an 8 bit
divider field, which seems to be always 0 in the current code. And I don't see any reference
to params_rate in the davinci-i2s.c file. Has anyone tried the cpu as master???
Troy
next prev parent reply other threads:[~2009-07-06 22:01 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 2:29 davinci-i2c,pcm updates Troy Kisky
2009-07-05 2:29 ` [PATCH V1 01/11] ASoC: DaVinci: i2s, remove MOD_REG_BIT macro Troy Kisky
2009-07-05 2:29 ` [PATCH V1 02/11] ASoC: DaVinci: i2s toggle clock to complete reset Troy Kisky
2009-07-05 2:29 ` [PATCH V1 03/11] ASoc: DaVinci: i2s, minor cleanup Troy Kisky
2009-07-05 2:29 ` [PATCH V1 04/11] ASoC: DaVinci: i2s cleanup Troy Kisky
2009-07-05 2:29 ` [PATCH V1 05/11] ASoC: DaVinci: i2s, only start sample generator if needed Troy Kisky
2009-07-05 2:29 ` [PATCH V1 06/11] ASoC: DaVinci: i2s, minor cleanup of davinci_i2s_startup Troy Kisky
2009-07-05 2:29 ` [PATCH V1 07/11] ASoC: DaVinci: i2s, fix mcbsp_word_length update Troy Kisky
2009-07-05 2:29 ` [PATCH V1 08/11] ASoc: DaVinci: i2s, Improve underrun, support mono Troy Kisky
2009-07-05 2:29 ` [PATCH V1 09/11] ASoC: DaVinci: i2s, add davinci_i2s_prepare and shutdown Troy Kisky
[not found] ` <1246761001-21982-10-git-send-email-troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-07-05 2:30 ` [PATCH V1 10/11] ASoC: DaVinci: i2s don't limit rates Troy Kisky
2009-07-05 2:30 ` [PATCH V1 11/11] ASoC: DaVinci: pcm, fix underruns by using sram Troy Kisky
2009-07-05 13:03 ` Mark Brown
2009-07-07 1:10 ` Troy Kisky
2009-07-07 9:31 ` Mark Brown
2009-07-07 19:07 ` Troy Kisky
2009-07-07 19:14 ` Troy Kisky
2009-07-07 19:21 ` Troy Kisky
2009-07-05 11:57 ` [PATCH V1 10/11] ASoC: DaVinci: i2s don't limit rates Mark Brown
2009-07-06 22:01 ` Troy Kisky [this message]
2009-07-06 22:19 ` Mark Brown
2009-07-06 22:27 ` Troy Kisky
2009-07-05 12:17 ` [PATCH V1 09/11] ASoC: DaVinci: i2s, add davinci_i2s_prepare and shutdown Mark Brown
2010-09-24 16:48 ` Ambrose, Martin
2010-09-24 19:14 ` Troy Kisky
2010-09-24 19:43 ` Ambrose, Martin
2010-09-24 23:13 ` Troy Kisky
2010-09-27 0:56 ` Mark Brown
2010-09-27 18:50 ` Troy Kisky
2010-09-27 20:35 ` Mark Brown
2010-09-27 0:27 ` Mark Brown
2009-07-05 12:12 ` [PATCH V1 08/11] ASoc: DaVinci: i2s, Improve underrun, support mono Mark Brown
[not found] ` <1246761001-21982-9-git-send-email-troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-07-06 11:09 ` Steve Chen
2009-07-06 11:54 ` Mark Brown
[not found] ` <20090706115442.GA8925-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-07-06 12:45 ` Steve Chen
2009-07-06 13:26 ` snd_pcm_format_set_silence parameter Guilherme Longo
2009-07-06 13:52 ` Clemens Ladisch
2009-07-05 11:41 ` davinci-i2c,pcm updates Mark Brown
2009-07-05 12:03 ` performance between access mothods! Guilherme Longo
2009-07-07 11:26 ` Takashi Iwai
2009-07-06 21:30 ` davinci-i2c,pcm updates Troy Kisky
2009-07-06 21:41 ` Mark Brown
2009-07-06 22:51 ` Kevin Hilman
2009-07-07 9:20 ` Mark Brown
2009-07-06 21:47 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A527452.6050304@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.