Re: [Qemu-devel] [PATCH] RFC: Add new block driver for the VDI format

[Kevin Wolf <kwolf@redhat.com>]

Stefan Weil schrieb:
> It would help if you could already commit the synchronous version
> as soon as the endianess issue (detected by Kevin Wolf, thanks)
> and an additional bug in the write code are fixed
> (code is ready, but still untested - a patch will follow this week).

Maybe somebody should run qemu-iotests for it on a big endian machine to
make sure it works. Unfortunately, I don't have one here.

For the write bug you might want to write a new qemu-iotests test case
as it doesn't seem to be covered yet (at least, Christoph said the
driver passes).

> I don't plan to change the code's license from GPL to MIT.
> This is a matter of my personal taste. Is this a problem
> for new block driver code?

I guess it's okay. It's just that until now the whole block code was
under a single license which I would have liked to retain. But again
just a matter of personal taste.

Kevin