From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Tue, 07 Jul 2009 15:42:31 +0000 Subject: Re: [PATCH 03/23] Add PPC64 fields to vcpu structs Message-Id: <4A536CE7.5070904@redhat.com> List-Id: References: <1246976262-4826-4-git-send-email-agraf@suse.de> In-Reply-To: <1246976262-4826-4-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On 07/07/2009 05:17 PM, Alexander Graf wrote: > We need to store more information than we currently have for vcpus > when running on PPC64. > > So let's extend the internal struct definitions. > > Signed-off-by: Alexander Graf > --- > arch/powerpc/include/asm/kvm_host.h | 80 ++++++++++++++++++++++++++++++++++- > 1 files changed, 79 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h > index c9c930e..80eeef7 100644 > --- a/arch/powerpc/include/asm/kvm_host.h > +++ b/arch/powerpc/include/asm/kvm_host.h > @@ -37,6 +37,8 @@ > #define KVM_NR_PAGE_SIZES 1 > #define KVM_PAGES_PER_HPAGE(x) (1UL<<31) > > +#define HPTEG_CACHE_NUM 1024 > + > struct kvm; > struct kvm_run; > struct kvm_vcpu; > @@ -63,6 +65,17 @@ struct kvm_vcpu_stat { > u32 dec_exits; > u32 ext_intr_exits; > u32 halt_wakeup; > +#ifdef CONFIG_PPC64 > + u32 pf_storage; > + u32 pf_instruc; > + u32 sp_storage; > + u32 sp_instruc; > + u32 queue_intr; > + u32 ld; > + u32 ld_slow; > + u32 st; > + u32 st_slow; > +#endif > }; > > My plan is to drop kvm_vcpu_stat in favor of tracepoints (you can have ftrace count tracepoints instead of recording them). You can do that later if you want to avoid the churn. -- error compiling committee.c: too many arguments to function