From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Tue, 07 Jul 2009 16:08:16 +0000 Subject: Re: [PATCH 00/23] Add KVM support for PPC64 (970) hosts Message-Id: <4A5372F0.7040800@redhat.com> List-Id: References: <1246976262-4826-1-git-send-email-agraf@suse.de> In-Reply-To: <1246976262-4826-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On 07/07/2009 06:56 PM, Alexander Graf wrote: >> From a quick review (not that I'm qualified to review ppc code) this >> looks very good. > > > Wow - thanks :-). Well, I only reviewed the code that I understood, which was the whitespace. Apparently that part is a well-formed program (see http://compsoc.dur.ac.uk/whitespace/). > > Or is using mmu_notifiers mandatory? :-). It's highly recommended. > I also found some mmu_notifiers parts in generic kvm code. Does that > mean it gets handled by that already? You just need to implement a hook that drops a gfn from your shadow page tables and tlbs. It should be fairly small. -- error compiling committee.c: too many arguments to function