From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"Kurt C. Hackel" <kurt.hackel@oracle.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Yu, Ke" <ke.yu@intel.com>
Subject: Re: dom0 hang
Date: Tue, 07 Jul 2009 11:28:25 -0700 [thread overview]
Message-ID: <4A5393C9.6020605@oracle.com> (raw)
In-Reply-To: <C678B6D7.EFC1%keir.fraser@eu.citrix.com>
Keir Fraser wrote:
> On 07/07/2009 08:14, "Yu, Ke" <ke.yu@intel.com> wrote:
>
>>> BTW, why can't the tick be suspended when csched_schedule() concludes
>>> it's idle vcpu before returning? won't that would make it less intrusive.
>> The tick suspend can be put in csched_schedule, but the suspend/resume logic
>> is still needed in acpi_processor_idle anyway, due to another dbs_timer
>> suspend/resume. The intention here is to make acpi_processor_idle the central
>> place for timers which are stoppable during idle period. If there is other
>> stoppable timer in the future, it can be easily added to acpi_processor_idle.
>> So it is clean to keep current logic. and as long as we carefully not over
>> doing the softirq, it looks not so intrusive. How do you think?
>
> I think the approach is fine. I also already applied your patch since it is
> obviously a good bug fix, even if it doesn't fix Mukesh's bug. And I fixed
> the comment at the same time. And I backported it for Xen 3.4.1.
>
> -- Keir
>
It fixes my bug.
Thanks,
Mukesh
prev parent reply other threads:[~2009-07-07 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 18:15 dom0 hang Mukesh Rathor
2009-07-02 3:19 ` Mukesh Rathor
2009-07-02 7:18 ` Keir Fraser
2009-07-02 17:50 ` George Dunlap
2009-07-02 19:14 ` Mukesh Rathor
[not found] ` <de76405a0907021349q20e47f5ave3cc86b74c511f0@mail.gmail.com>
[not found] ` <4A4D2253.8070807@oracle.com>
2009-07-02 21:37 ` George Dunlap
2009-07-03 0:14 ` Mukesh Rathor
2009-07-03 1:18 ` Mukesh Rathor
2009-07-03 4:48 ` Yu, Ke
2009-07-03 5:09 ` Yu, Ke
2009-07-07 3:46 ` Mukesh Rathor
2009-07-07 7:14 ` Yu, Ke
2009-07-07 7:24 ` Keir Fraser
2009-07-07 18:28 ` Mukesh Rathor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5393C9.6020605@oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=ke.yu@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=kurt.hackel@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.