From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOFQe-0001h9-JI for qemu-devel@nongnu.org; Tue, 07 Jul 2009 14:30:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOFQZ-0001ba-NA for qemu-devel@nongnu.org; Tue, 07 Jul 2009 14:30:07 -0400 Received: from [199.232.76.173] (port=46198 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOFQZ-0001bF-HW for qemu-devel@nongnu.org; Tue, 07 Jul 2009 14:30:03 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:37896) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOFQY-0004ay-Tc for qemu-devel@nongnu.org; Tue, 07 Jul 2009 14:30:03 -0400 Message-ID: <4A539426.2020507@web.de> Date: Tue, 07 Jul 2009 20:29:58 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <200906300055.n5U0tAD8013302@d03av01.boulder.ibm.com> <4A4F3967.9040106@web.de> <4A511F7B.6040504@web.de> <1246897688.6429.89.camel@localhost> In-Reply-To: <1246897688.6429.89.camel@localhost> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6307E868C900072593345573" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [COMMIT 707c0db] support colon in filenames List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: linuxram@us.ibm.com Cc: Anthony Liguori , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6307E868C900072593345573 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Ram Pai wrote: > On Sun, 2009-07-05 at 23:47 +0200, Jan Kiszka wrote: >> Jan Kiszka wrote: >>> Anthony, >>> >>> please revert this patch until Ram Pai provides a better version. It >>> causes too many problems. At least it > Jan, >=20 > Yes I am working on the next revision of the patch.=20 I'm ok with keeping the change if you commit yourself to fix the regressions quickly. >=20 >>> - breaks -pflash somefile -snapshot >> Some more details on this: it's not just pflash that suffers, -snapsho= t >> was broken for raw images in general. Declaring file access as a >> protocol apparently has some unwanted side effects that first have to = be >> resolved (check also bdrv_open2 /wrt realpath). >=20 > I do not entirely understand the side effect. I will see if I can figur= e > this out. It will certainly help if you can elaborate more? Start with running/debugging 'qemu raw.image -snapshot'. Also study the codepath bdrv_open2 takes when snapshot is enabled. Specifically watch out for realpath(). I'm not sure ATM why it is needed, but it used to be applied on all file paths. >=20 >>> - breaks mingw32 build due to redefined _open >> Sorry, this obviously does not apply to the merged revision 2 but to >> rev3 which I had applied locally. >> >>> - uses PATH_MAX >=20 > PATH_MAX is not defined in mingw32 environment?=20 It may not be defined in all environments (I've recently stumbled over this with a patch, too), and it's possible that PATH_MAX < strlen(path). Given that you can measure the input path length and the fact that the output path cannot be larger, allocating this buffer from the heap is really straightforward. Jan --------------enig6307E868C900072593345573 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpTlCcACgkQniDOoMHTA+n1kQCeMeKziAx1VbLVJ0ixxKRpyHEH VOkAnAntacdIe3dVNrWCA9Ld/DVOaw8P =mUjN -----END PGP SIGNATURE----- --------------enig6307E868C900072593345573--