[Ocfs2-devel] [PATCH 5/5] ocfs2: Disable orphan scanning for local and hard-ro mounts

[Sunil Mushran <sunil.mushran@oracle.com>]

Jeff Mahoney wrote:
> There's a problem with this patch that I ran into while testing
> 2.6.31-rc2. ocfs2_orphan_scan_stop expects that ocfs2_orphan_scan_init
> was called. If the mount fails for any reason, ocfs2_dismount_volume
> calls ocfs2_orphan_scan_stop. The thing is that ocfs2_dismount_volume
> will never get called in that path after ocfs2_orphan_scan_init is
> called, so we oops when calling cancel_delayed_work on an uninitialized
> work queue.
>
> The attached patch fixes it up.
>
> -Jeff

Jeff, Thanks. For some reason, my mounts don't fail. ;)

My only quibble with the patch would be that ocfs2_orphan_scan_init()
should be called before ocfs2_recovery_init(). Else we'll encounter the
same problem if say ocfs2_recovery_init() fails.