From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick Colp <Patrick.Colp@citrix.com>
Subject: Re: [PATCH]Fix vlapic.h type
Date: Wed, 8 Jul 2009 10:31:03 +0100
Message-ID: <4A546757.5030205@citrix.com>
References: <4A53BC08.1040100@amd.com> <4A544B76.6000304@citrix.com>
	<4A5463A6.5030001@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4A5463A6.5030001@solarflare.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Neil Turton <nturton@solarflare.com>
Cc: Wei Huang <wei.huang2@amd.com>, "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Neil Turton wrote:
> Patrick Colp wrote:
>> Good catch. This line:
>>
>>   #define vlapic_vcpu(vpic)   (container_of((vpic), struct vcpu, \
>>                                             arch.hvm_vcpu.vlapic))
>>
>> should probably also be changed to this:
>>
>>   #define vlapic_vcpu(vlapic)   (container_of((vlapic), struct vcpu, \
>>                                               arch.hvm_vcpu.vlapic))
> 
> I'm not sure.  Do you intend to change the member name after hvm_vcpu
> based on the macro parameter?

No. Why would I do that?

The issue here is that the macro parameter is referring to a vlapic and not a 
vpic (which is something different). So for the sake of clarity, it should be 
changed to vlapic instead of vpic.


Patrick