From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Colp Subject: Re: [PATCH]Fix vlapic.h type Date: Wed, 8 Jul 2009 10:38:22 +0100 Message-ID: <4A54690E.3080709@citrix.com> References: <4A53BC08.1040100@amd.com> <4A544B76.6000304@citrix.com> <4A5463A6.5030001@solarflare.com> <4A546757.5030205@citrix.com> <20090708093346.GA5235@york.uk.xensource.com> <4A546851.60708@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A546851.60708@solarflare.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Neil Turton Cc: Tim Deegan , Wei Huang , "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org Right, sorry. My bad. However, calling it vpic is still a bad idea :) _vlapic or _v or even v would be a better choice. Patrick Neil Turton wrote: > Tim Deegan wrote: >> but vlapic_vcpu(oops) would expand to >> (container_of((oops), struct vcpu, arch.hvm_vcpu.oops) >> ^^^^ > > Thanks, Tim. That's what I was trying to say. > > Cheers, Neil.