Re: [PATCH] add block IO documentation to tracepoint docbook

[William Cohen <wcohen@redhat.com>]

Li Zefan wrote:
> More CCed
> 
> William Cohen wrote:
>> The following patch adds block IO tracepoint documentation to the tracepoint
>> docbook.
>>
>> Signed-off-by: William Cohen <wcohen@xxxxxxxxxx>
> 
> Nice, thanks!
> 
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
> 
>> +/**
>> + * block_rq_abort - Abort Block Operation Request
> 
> Is it necessary to uppercase the first letter of every word?

I was assuming that it was a title. However, lower case would be okay.

-Will
> 
>> + * @q: queue containing the block operation request
>> + * @rq: block IO operation request
>> + *
>> + * Called immediately after pending block IO operation request @rq in
>> + * queue @q is aborted. The fields in the operation request @rq
>> + * can be examined to determine which device and sectors the pending
>> + * operation would access.
>> + */
>>  TRACE_EVENT(block_rq_abort,
>>  
>>  	TP_PROTO(struct request_queue *q, struct request *rq),
> 
>