From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOZYm-0003h3-JL for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:59:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOZYh-0003eL-Qw for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:59:51 -0400 Received: from [199.232.76.173] (port=48104 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOZYh-0003eD-FH for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:59:47 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38769) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOZYg-0004CX-VJ for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:59:47 -0400 Message-ID: <4A54C308.8060307@redhat.com> Date: Wed, 08 Jul 2009 19:02:16 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot References: <20090707192631.GQ11590@us.ibm.com> <20090708075601.GJ28046@redhat.com> <4A549990.2060205@us.ibm.com> <20090708132623.GN26640@redhat.com> <4A54A367.3010603@us.ibm.com> <20090708135607.GO26640@redhat.com> <20090708154349.GT11590@us.ibm.com> In-Reply-To: <20090708154349.GT11590@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ryan Harper Cc: Anthony Liguori , qemu-devel@nongnu.org, Gleb Natapov On 07/08/2009 06:43 PM, Ryan Harper wrote: >> That suffers from the same problem as a system_reboot command in that >> the guest may never start the shutdown. If that's an acceptable >> limitation, then we might as well implement it directly in QEMU as >> system_reboot so its easily available to everyone. Make 'system_reboot' >> take an optional timeout arg (default to 60 seconds) after which it >> cancels its plans. >> > > This seems the most reasonable thing to me. As already mentioned, > system_powerdown already is non-deterministic since the guest could > ignore the ACPI event. > It could also send the guest to sleep or initiate the self destruct sequence. I don't think we should press the power button unless the user explicitly asked us to. This means we'll need a guest agent like Xen. I believe ACPI supports additional buttons, we can add a new one and designate it as a shutdown button. It will only work with modified guests though. -- error compiling committee.c: too many arguments to function