From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure Date: Wed, 08 Jul 2009 21:44:26 +0200 Message-ID: <4A54F71A.8000407@web.de> References: <1247058542-31211-1-git-send-email-glommer@redhat.com> <1247058542-31211-2-git-send-email-glommer@redhat.com> <1247058542-31211-3-git-send-email-glommer@redhat.com> <1247058542-31211-4-git-send-email-glommer@redhat.com> <1247058542-31211-5-git-send-email-glommer@redhat.com> <1247058542-31211-6-git-send-email-glommer@redhat.com> <1247058542-31211-7-git-send-email-glommer@redhat.com> <1247058542-31211-8-git-send-email-glommer@redhat.com> <4A549EBF.5040900@redhat.com> <20090708133941.GY3528@poweredge.glommer> <4A54A2A7.7040309@redhat.com> <4A54B9E7.9000801@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1AA6B8B0E3AFD747E794DA2E" Cc: kvm@vger.kernel.org To: Avi Kivity , Glauber Costa Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:60863 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbZGHTpY (ORCPT ); Wed, 8 Jul 2009 15:45:24 -0400 In-Reply-To: <4A54B9E7.9000801@web.de> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1AA6B8B0E3AFD747E794DA2E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Jan Kiszka wrote: > Avi Kivity wrote: >> On 07/08/2009 04:39 PM, Glauber Costa wrote: >>> On Wed, Jul 08, 2009 at 04:27:27PM +0300, Avi Kivity wrote: >>> =20 >>>> On 07/08/2009 04:09 PM, Glauber Costa wrote: >>>> =20 >>>>> Signed-off-by: Glauber Costa >>>>> --- >>>>> kvm-all.c | 27 ++++++++++++++++++--------- >>>>> qemu-kvm.h | 6 +++--- >>>>> target-i386/kvm.c | 4 ++-- >>>>> 3 files changed, 23 insertions(+), 14 deletions(-) >>>>> >>>>> >>>>> =20 >>>> Did you test the functionality to ensure we do not regress? >>>> =20 >>> just briefly. To be honest, I'd feel much more confortable >>> if Jan could give it a try. >>> =20 >> A Jan try (+review) will definitely help. >> >=20 > Queued. >=20 Deferred until v2. My first impression is that too much upstream code is moved or touched. Glauber, if you want to use some function that is currently under KVM_UPSTREAM, don't move it, just drop the #ifdef around it. And when done, have a look at the diff between upstream and qemu-kvm to avoid unneeded variations. Another question: What prevents using CONFIG_KVM also for qemu-kvm? I would rather mask out yet unused upstream code via the well-known KVM_UPSTREAM and drop the easily confusable USE_KVM defines. Jan --------------enig1AA6B8B0E3AFD747E794DA2E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkpU9x4ACgkQniDOoMHTA+n9xQCePzjWvMXbwmL1QY+KRk84qZOx mTkAnRx6Zomtba8AOjL3oYvW1duD+JNd =TerD -----END PGP SIGNATURE----- --------------enig1AA6B8B0E3AFD747E794DA2E--