Re: [PATCH v2] input:Add clk api support for w90p910 touchscreen

[Wan ZongShun <mcuos.com@gmail.com>]

Dear Russell,


>>>>> Umm, one more thing - we need to add "depends on" to Kconfig since
>>>>> clk API is not implemented on every platform. Any ideas what is the
>>>>> most wide dependency is?
>>>> The most wide dependency for the clk API is HAVE_CLK.
>>>>
>>> Cool, thanks.
>>>
>> Sure, but why to add it to touchscreen's kconfig?
>> it seems it should be put arch/arm/kconfig.
>>
>> In addition,I never use this HAVE_CLK in ARCH_W90X900, 
>> only using COMMON_CLKDEV to support clk API. 
> 
> HAVE_CLK is the configuration symbol which tells the rest of the kernel
> configuration system that the clk API is available.  Drivers using the
> clk API should depend on HAVE_CLK.
> 
> COMMON_CLKDEV is just one implementation of a subset of the clk API, and
> nothing should ever depend on this symbol.
> 
 Maybe I should add this "select HAVE_CLK" to arch/arm/Kconfig too, as following:

config ARCH_W90X900
	bool "Nuvoton W90X900 CPU"
	select CPU_ARM926T
	select ARCH_REQUIRE_GPIOLIB
	select GENERIC_GPIO
	select COMMON_CLKDEV
	select HAVE_CLK

Is it right?

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php