From: "Lukáš Doktor" <ldoktor@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>, Jason Wang <jasowang@redhat.com>
Subject: Re: [KVM_AUTOTEST] add kvm hugepage variant and test
Date: Thu, 09 Jul 2009 14:55:12 +0200 [thread overview]
Message-ID: <4A55E8B0.1@redhat.com> (raw)
In-Reply-To: <119650285.208601247142612126.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Hi Michael,
actually it's necessarily. qemu-kvm only put this message into the
output and continue booting the guest without hugepage support. Autotest
than runs all the test. Later in the output is no mention about this.
You have to predict that this happend and look at debug output of all
particular tests to see if qemu didn't produced this message.
Using this check if qemu-kvm can't allocate the hugepage memory it fails
this test, log this information and continue with next variant.
Dne 9.7.2009 14:30, Michael Goldish napsal(a):
> I don't think you need to explicitly check for a memory allocation
> failure in VM.create() ("qemu produced some output ...").
> VM.create() already makes sure the VM is started successfully, and
> prints informative failure messages if there's any problem.
>
> ----- "Lukáš Doktor"<ldoktor@redhat.com> wrote:
>
>> This patch adds kvm_hugepage variant. It prepares the host system and
>> start vm with -mem-path option. It does not clean after itself,
>> because
>> it's impossible to unmount and free hugepages before all guests are
>> destroyed.
>>
>> There is also added autotest.libhugetlbfs test.
>>
>> I need to ask you what to do with change of qemu parameter. Newest
>> versions are using -mempath insted of -mem-path. This is impossible to
>> fix using current config file. I can see 2 solutions:
>> 1) direct change in kvm_vm.py (parse output and try another param)
>> 2) detect qemu capabilities outside and create additional layer
>> (better
>> for future occurrence)
>
> I'll have to think about this a little before answering.
>
>> Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-07-09 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 9:24 [KVM_AUTOTEST] add kvm hugepage variant and test Lukáš Doktor
2009-07-09 12:30 ` Michael Goldish
2009-07-09 12:55 ` Lukáš Doktor [this message]
2009-07-10 4:38 ` sudhir kumar
2009-07-10 6:48 ` Lukáš Doktor
2009-07-10 8:03 ` Lukáš Doktor
2009-07-10 10:01 ` [KVM_AUTOTEST] add kvm hugepage variant Lukáš Doktor
2009-07-20 12:58 ` Lucas Meneghel Rodrigues
2009-07-21 16:04 ` Lukáš Doktor
2009-07-22 5:57 ` [Autotest] " sudhir kumar
2009-07-27 21:05 ` Lucas Meneghel Rodrigues
2009-07-10 10:04 ` [KVM_AUTOTEST] add autotest.libhugetlbfs test Lukáš Doktor
2009-07-10 10:37 ` sudhir kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A55E8B0.1@redhat.com \
--to=ldoktor@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.