From: Casey Schaufler <casey@schaufler-ca.com>
To: Eric Paris <eparis@redhat.com>
Cc: Thomas Liu <tliu@redhat.com>,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
chrisw@sous-sol.org, sds@tycho.nsa.gov, jmorris@namei.org,
eparis@parisplace.org, etienne.basset@numericable.fr
Subject: Re: [PATCH 1/3] Move variable function in lsm_audit.h into SMACK private space
Date: Thu, 09 Jul 2009 07:50:39 -0700 [thread overview]
Message-ID: <4A5603BF.6010809@schaufler-ca.com> (raw)
In-Reply-To: <1247149402.2830.16.camel@dhcp235-23.rdu.redhat.com>
Eric Paris wrote:
> On Thu, 2009-07-09 at 07:17 -0700, Casey Schaufler wrote:
>
>> Thomas Liu wrote:
>>
>>> Moved variable function in include/linux/lsm_audit.h into the
>>> smack_audit_data struct since it is never used outside of it.
>>>
>>>
>> What value does this change provide?
>>
>
> By itself, none other than proper abstracting. ->function is a smack
> specific object so it shouldn't be in the generic space. Along with
> patch #3 it saves memory on systems that choose to build without SMACK.
>
I don't see any problems with it then.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2009-07-09 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 14:00 [PATCH 1/3] Move variable function in lsm_audit.h into SMACK private space Thomas Liu
2009-07-09 14:04 ` Eric Paris
2009-07-09 14:17 ` Casey Schaufler
2009-07-09 14:23 ` Eric Paris
2009-07-09 14:50 ` Casey Schaufler [this message]
2009-07-09 22:56 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5603BF.6010809@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=chrisw@sous-sol.org \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=etienne.basset@numericable.fr \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=tliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.