From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibility.
Date: Thu, 09 Jul 2009 17:17:43 +0200 [thread overview]
Message-ID: <4A560A17.6020202@redhat.com> (raw)
In-Reply-To: <20090709144004.GB26895@redhat.com>
On 07/09/09 16:40, Michael S. Tsirkin wrote:
> The number of vectors is part of hardware config so it's not a good idea
> to use a binary property here. Since<= vectors is not a legal msi
> configuration, it's enough to implement a "vectors" property instead:
> virtio already interprets zero vectors as no msi. This also matches
> command line/monitor syntax, which is a good thing.
Ok, it makes sense to have a vectors property then.
Will rewrite the patch.
cheers,
Gerd
prev parent reply other threads:[~2009-07-09 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 13:02 [Qemu-devel] [PATCH 0/5] qdev: compat properties Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 1/5] qdev/compat: compat property infrastructure Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 2/5] qdev/compat: add pc-0.10 machine type Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 3/5] qdev/compat: virtio-blk-pci 0.10 compatibility Gerd Hoffmann
2009-07-09 14:52 ` Michael S. Tsirkin
2009-07-09 15:09 ` Gerd Hoffmann
2009-07-09 18:20 ` Michael S. Tsirkin
2009-07-09 19:42 ` Filip Navara
2009-07-09 19:45 ` Michael S. Tsirkin
2009-07-09 15:50 ` Anthony Liguori
2009-07-09 13:02 ` [Qemu-devel] [PATCH 4/5] qdev/compat: virtio-balloon-pci " Gerd Hoffmann
2009-07-09 13:02 ` [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci " Gerd Hoffmann
2009-07-09 14:40 ` Michael S. Tsirkin
2009-07-09 15:17 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A560A17.6020202@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.