From: Stephen Boyd <bebarino@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 4/4] prune-packed: migrate to parse-options
Date: Thu, 09 Jul 2009 08:55:50 -0700 [thread overview]
Message-ID: <4A561306.9010908@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0907091250120.4339@intel-tinevez-2-302>
Johannes Schindelin wrote:
> Hi,
>
> I reviewed all four patches, and like them. Just a minor nit:
>
> On Tue, 7 Jul 2009, Stephen Boyd wrote:
>
>> Add --dry-run and --quiet to be more consistent with the rest of git.
>>
>
> You should say here that you add the _long_ options (the short options
> were supported already); I almost expected you to sneak in additional
> features with the parseoptification.
>
> Same goes for 3/4, I guess.
>
Sure, this sounds reasonable. I'll send follow up commit message fixups.
next prev parent reply other threads:[~2009-07-09 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 5:15 [PATCH 0/4] Migrate simple builtins to parse-options Stephen Boyd
2009-07-08 5:15 ` [PATCH 1/4] write-tree: migrate " Stephen Boyd
2009-07-08 5:15 ` [PATCH 2/4] tag-verify: " Stephen Boyd
2009-07-08 5:15 ` [PATCH 3/4] verify-pack: " Stephen Boyd
2009-07-08 5:15 ` [PATCH 4/4] prune-packed: " Stephen Boyd
2009-07-09 10:51 ` Johannes Schindelin
2009-07-09 15:55 ` Stephen Boyd [this message]
2009-07-09 16:05 ` Stephen Boyd
2009-07-09 16:01 ` [PATCH 3/4] verify-pack: " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A561306.9010908@gmail.com \
--to=bebarino@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.