All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] unknown segment types, part 1
Date: Thu, 09 Jul 2009 19:27:43 +0200	[thread overview]
Message-ID: <4A56288F.4080604@redhat.com> (raw)
In-Reply-To: <87ljmzcz28.fsf@twilight.int.mornfall.net.>

Petr Rockai wrote:
> the attached patch makes LVM handle unknown segment types by a simple
> copy-through mechanism, i.e. whenever an unknown segment is encountered, it is
> left intact (and preserved) by LVM. We may still want to limit changes to LVs
> that contain unknown segments, and maybe even some heuristic to find LV
> references in unknown segments (hard to tell).
> 
> There's also one thread-unsafe bit in the patch, that's not so hard to fix, but
> I'll do that when we know that this is the right direction we want to take.
> 
> (The patch itself will probably need another iteration. Consider this to be a
> draft.)

After short testing (yes, there are nice bugs :-) I have several questions:

- Why activate "unknown" segment by replacing it by error segment?
I think that ignoring LV including unknown segment (with some error message)
but not activate is better.

Or use some configurable option? 

- Do we want code to preserve (read: kill unknown options) metadata when
segment handler is not loaded?

Isn't better just allow only read-only metadata operation
(so "unknown" segment will appear only in-memory metadata, never on-disk).

Possibly add some option to vgck to "fix" unknown segments.

Milan



  reply	other threads:[~2009-07-09 17:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08  9:18 [PATCH] unknown segment types, part 1 Petr Rockai
2009-07-09 17:27 ` Milan Broz [this message]
2009-07-09 17:53   ` Milan Broz
2009-07-09 19:50     ` Petr Rockai
2009-07-09 19:54   ` Petr Rockai
2009-07-09 20:11     ` Milan Broz
2009-07-21 14:41       ` [PATCH, v2] unknown segment types Petr Rockai
2009-09-29 14:42         ` Petr Rockai
2009-10-07 20:03           ` Dave Wysochanski
2009-10-07 20:53           ` [PATCH, v3] " Petr Rockai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A56288F.4080604@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.