All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [PATCH 2/2] tracing/kmemtrace: Use the %pf format
Date: Fri, 10 Jul 2009 13:17:44 +0800	[thread overview]
Message-ID: <4A56CEF8.8040106@cn.fujitsu.com> (raw)
In-Reply-To: <1247107590-6428-3-git-send-email-fweisbec@gmail.com>

Frederic Weisbecker wrote:
> Remove the obsolete seq_print_ip_sym() usage and replace it
> by the %pf format in order to print function symbols.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>

...

> -	/* Skip node */
> -	ret = trace_seq_printf(s, "       ");
> +	/* Skip node and print call site*/

a nitpick:

missing a space before '*/'

> +	ret = trace_seq_printf(s, "       %pf\n", (void *)entry->call_site);


  reply	other threads:[~2009-07-10  5:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  2:46 [PATCH 0/2] tracing: convert some seq_print_ip_sym to %pf Frederic Weisbecker
2009-07-09  2:46 ` [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format Frederic Weisbecker
2009-07-10  5:14   ` Li Zefan
2009-07-10 10:42   ` [tip:tracing/core] " tip-bot for Frederic Weisbecker
2009-07-09  2:46 ` [PATCH 2/2] tracing/kmemtrace: " Frederic Weisbecker
2009-07-10  5:17   ` Li Zefan [this message]
2009-07-10 10:42   ` [tip:tracing/core] " tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A56CEF8.8040106@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=fweisbec@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.