All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wengang Wang <wen.gang.wang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] a fix of logging return value.
Date: Fri, 10 Jul 2009 14:22:07 +0800	[thread overview]
Message-ID: <4A56DE0F.3050009@oracle.com> (raw)
In-Reply-To: <3A2AA175-B34E-4A01-8B9E-45361846B18C@oracle.com>

Hi Sunil,

Ok. I will post patche(s) for it later.

regards,
wengang.

Sunil Mushran wrote:
> sob
> 
> Hi Wengang, functions is aops.c are missing mlogs. Do you have the 
> bandwidth to help out?
> 
> On Jul 9, 2009, at 10:26 PM, Wengang Wang <wen.gang.wang@oracle.com> wrote:
> 
>>    in ocfs2_file_aio_write(), log_exit() could don't log the value
>> which is really returned. this patch fixes it.
>>
>> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
>> ---
>> fs/ocfs2/file.c |    4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
>> index 62442e4..a49fa44 100644
>> --- a/fs/ocfs2/file.c
>> +++ b/fs/ocfs2/file.c
>> @@ -1918,8 +1918,10 @@ out_sems:
>>
>>    mutex_unlock(&inode->i_mutex);
>>
>> +    if (written)
>> +        ret = written;
>>    mlog_exit(ret);
>> -    return written ? written : ret;
>> +    return ret;
>> }
>>
>> static int ocfs2_splice_to_file(struct pipe_inode_info *pipe,
>> -- 
>> 1.6.2.5
>>

  reply	other threads:[~2009-07-10  6:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10  5:26 [Ocfs2-devel] [PATCH 1/1] a fix of logging return value Wengang Wang
2009-07-10  5:39 ` Sunil Mushran
2009-07-10  6:22   ` Wengang Wang [this message]
2009-07-10  6:40     ` Wengang Wang
2009-07-10  6:51       ` Tao Ma
2009-07-10 18:13         ` Sunil Mushran
2009-07-10 23:55 ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A56DE0F.3050009@oracle.com \
    --to=wen.gang.wang@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.