All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int.
Date: Fri, 10 Jul 2009 07:53:44 -0500	[thread overview]
Message-ID: <4A5739D8.60405@codemonkey.ws> (raw)
In-Reply-To: <20090710082121.GB5471@const.bordeaux.inria.fr>

Samuel Thibault wrote:
> Anthony Liguori, le Thu 09 Jul 2009 14:07:47 -0500, a écrit :
>   
>> Isaku Yamahata wrote:
>>     
>>> use uint32_t for ioport port and value instead of int.
>>>  
>>>       
>> Why?
>>     
>
> In theory int could be only signed 16bit, so at least unsigned int could
> be needed for the port.

There's no platform that QEMU runs on that has a 16-bit integer and it's 
extraordinarily unlikely that there ever will be.

But the point is, patches need descriptive changelogs saying why there 
making a change, not just what the change is.

Regards,

Anthony Liguori

      parent reply	other threads:[~2009-07-10 12:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 10:32 [Qemu-devel] [PATCH 0/6] ioport related clean ups Isaku Yamahata
2009-07-02 10:32 ` [Qemu-devel] [PATCH 1/6] split out ioport related stuffs from vl.c into ioport.c Isaku Yamahata
2009-07-02 10:32 ` [Qemu-devel] [PATCH 2/6] use constant IOPORTS_MASK instead of 0xffff Isaku Yamahata
2009-07-02 10:32 ` [Qemu-devel] [PATCH 3/6] ioport: consolidate duplicated logic in register_ioport_{read, write}() Isaku Yamahata
2009-07-02 10:32 ` [Qemu-devel] [PATCH 4/6] ioport: remove some #ifdef DEBUG_UNUSED_IOPORT Isaku Yamahata
2009-07-02 10:32 ` [Qemu-devel] [PATCH 5/6] consolidate user cpu_{in, out}[bwl] into ioport-user.c Isaku Yamahata
2009-07-02 10:32 ` [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int Isaku Yamahata
2009-07-02 18:11   ` Stuart Brady
2009-07-02 18:30     ` Stuart Brady
2009-07-09 19:07   ` Anthony Liguori
2009-07-10  8:21     ` Samuel Thibault
2009-07-10  8:45       ` Isaku Yamahata
2009-07-10  8:54         ` Samuel Thibault
2009-07-10  9:09           ` Tristan Gingold
2009-07-10 12:59             ` Anthony Liguori
2009-07-10 13:12               ` Tristan Gingold
2009-07-10 13:16                 ` Anthony Liguori
2009-07-10 13:28                   ` Tristan Gingold
2009-07-10 12:55         ` Anthony Liguori
2009-07-13  3:14           ` Isaku Yamahata
2009-07-13 18:59             ` Anthony Liguori
2009-07-13 21:19               ` Stuart Brady
2009-07-13 21:28                 ` Anthony Liguori
2009-07-14  1:58               ` Isaku Yamahata
2009-07-10 12:53       ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5739D8.60405@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@gnu.org \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.