All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Paul Brook <paul@codesourcery.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Sparc64 breakage by 16eaedf2668e9b347a59d73346fcc4c764c58348
Date: Fri, 10 Jul 2009 21:47:31 +0200	[thread overview]
Message-ID: <4A579AD3.1000903@redhat.com> (raw)
In-Reply-To: <4A579828.6010000@codemonkey.ws>

On 07/10/09 21:36, Anthony Liguori wrote:
> Blue Swirl wrote:
>> Hi,
>>
>> APB is not converted to qdev yet, so pci_register_secondary_bus
>> shouldn't use FROM_QBUS. Sparc64 is currently broken.

>> Partially reverting 16eaed... fixes the breakage:
>> --- a/hw/pci.c
>> +++ b/hw/pci.c
>> - bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
>> + bus = qemu_mallocz(sizeof(PCIBus));

> Gerd, could you take a look?

As sparc64 is the only user of pci_register_secondary_bus() the partial 
reverse is fine IMHO.  Just let us defer this until APB is qdev-ified.

cheers,
   Gerd

  reply	other threads:[~2009-07-10 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10 19:10 [Qemu-devel] Sparc64 breakage by 16eaedf2668e9b347a59d73346fcc4c764c58348 Blue Swirl
2009-07-10 19:36 ` Anthony Liguori
2009-07-10 19:47   ` Gerd Hoffmann [this message]
2009-07-10 19:48   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A579AD3.1000903@redhat.com \
    --to=kraxel@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.