From: Jiri Slaby <jirislaby@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Julia Lawall <julia@diku.dk>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test
Date: Sat, 11 Jul 2009 11:06:45 +0000 [thread overview]
Message-ID: <4A587245.1080304@gmail.com> (raw)
In-Reply-To: <1247307444.3032.2.camel@hpdv5.satnam>
On 07/11/2009 12:17 PM, Jaswinder Singh Rajput wrote:
> On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote:
>> On 07/11/2009 09:51 AM, Julia Lawall wrote:
>>> --- a/drivers/staging/otus/wwrap.c
>>> +++ b/drivers/staging/otus/wwrap.c
>>> @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
>>> {
>>> struct usbdrv_private *macp >>> container_of(work, struct usbdrv_private, kevent);
>>> - zdev_t *dev = macp->device;
>>> + zdev_t *dev;
>>>
>>> if (macp = NULL)
>>> {
>>> return;
>>> }
>>
>> The test is rather useless here.
>>
>
> Why useless, it should be non-null before setting to dev.
Even if work was NULL, macp won't be NULL.
> But issue is why function name like kevent() is global and who is using
> it.
Since it's not declared, I guess nobody but keventd. It should be static.
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Julia Lawall <julia@diku.dk>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test
Date: Sat, 11 Jul 2009 13:06:45 +0200 [thread overview]
Message-ID: <4A587245.1080304@gmail.com> (raw)
In-Reply-To: <1247307444.3032.2.camel@hpdv5.satnam>
On 07/11/2009 12:17 PM, Jaswinder Singh Rajput wrote:
> On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote:
>> On 07/11/2009 09:51 AM, Julia Lawall wrote:
>>> --- a/drivers/staging/otus/wwrap.c
>>> +++ b/drivers/staging/otus/wwrap.c
>>> @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
>>> {
>>> struct usbdrv_private *macp =
>>> container_of(work, struct usbdrv_private, kevent);
>>> - zdev_t *dev = macp->device;
>>> + zdev_t *dev;
>>>
>>> if (macp == NULL)
>>> {
>>> return;
>>> }
>>
>> The test is rather useless here.
>>
>
> Why useless, it should be non-null before setting to dev.
Even if work was NULL, macp won't be NULL.
> But issue is why function name like kevent() is global and who is using
> it.
Since it's not declared, I guess nobody but keventd. It should be static.
next prev parent reply other threads:[~2009-07-11 11:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 7:51 [PATCH 5/5] staging/otus: Move a dereference below a NULL test Julia Lawall
2009-07-11 7:51 ` Julia Lawall
2009-07-11 8:17 ` Jiri Slaby
2009-07-11 8:17 ` Jiri Slaby
2009-07-11 8:31 ` Julia Lawall
2009-07-11 8:31 ` Julia Lawall
2009-07-11 10:17 ` Jaswinder Singh Rajput
2009-07-11 10:29 ` Jaswinder Singh Rajput
2009-07-11 10:32 ` Jaswinder Singh Rajput
2009-07-11 10:44 ` Jaswinder Singh Rajput
2009-07-11 11:09 ` Jiri Slaby
2009-07-11 11:09 ` Jiri Slaby
2009-07-13 17:00 ` Luis R. Rodriguez
2009-07-13 17:00 ` Luis R. Rodriguez
2009-07-11 11:06 ` Jiri Slaby [this message]
2009-07-11 11:06 ` Jiri Slaby
2009-07-11 11:32 ` Julia Lawall
2009-07-11 11:32 ` Julia Lawall
2009-07-11 11:58 ` Julia Lawall
2009-07-11 11:58 ` Julia Lawall
2009-07-11 17:03 ` Greg KH
2009-07-11 17:03 ` Greg KH
2009-07-11 18:28 ` Julia Lawall
2009-07-11 18:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A587245.1080304@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jaswinder@kernel.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.