Re: [PATCH 03/10] Defer mount to the real mount loop

[Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 07/04/2009 02:29 PM, Seewer Philippe wrote:
>> -echo "iscsi_lun=$iscsi_lun . /bin/mount-lun.sh " > /mount/iscsi.sh
>> +echo "iscsi_lun=$iscsi_lun . /bin/mount-lun.sh " > /mount/01-$$-iscsi.sh
>
> I'd do that after iscsistart. That way the file is only written if
> iscsistart succeeded.

right

>
>>
>> iscsistart -i $iscsi_initiator -t $iscsi_target_name \
>> -g $iscsi_target_group -a $iscsi_target_ip \
>> diff --git a/modules.d/95nbd/nbdroot b/modules.d/95nbd/nbdroot
>> index ad2e906..ecac211 100755
>> --- a/modules.d/95nbd/nbdroot
>> +++ b/modules.d/95nbd/nbdroot
>> @@ -93,9 +93,10 @@ done
>> # If we didn't get a root= on the command line, then we need to
>> # add the udev rules for mounting the nbd0 device
>> if [ ! -e /etc/udev/rules.d/99-mount.rules ]; then
>> - printf 'KERNEL=="%s", RUN+="/sbin/initqueue /bin/mount -t %s -o %s
>> %s %s"\n' \
>> - nbd0 "$nbdfstype" "$fsopts" /dev/nbd0 "$NEWROOT" \
>> - > /etc/udev/rules.d/99-mount.rules
>> + printf 'KERNEL=="nbd0", SYMLINK+="root"\n'>
>> /etc/udev/rules.d/99-mount.rules
>> + printf '/bin/mount -t %s -o %s %s %s\n' \
>> + "$nbdfstype" "$fsopts" /dev/nbd0 "$NEWROOT" \
>> + > /mount/01-$$-nbd.sh
>> fi
>
> Same here, I'd only write a mount-script if nbdclient succeeds.

yep
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html