From: Ameya Palande <ameya.palande@nokia.com>
To: "x0095840@ti.com" <x0095840@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"h-kanigeri2@ti.com" <h-kanigeri2@ti.com>,
"Carmody Phil.2 (EXT-Ixonos/Helsinki)"
<ext-phil.2.carmody@nokia.com>
Subject: Re: [PATCHv2 1/4] DSPBRIDGE: Fix macros that break when inside an if/else
Date: Mon, 13 Jul 2009 15:42:12 +0300 [thread overview]
Message-ID: <4A5B2BA4.1090506@nokia.com> (raw)
In-Reply-To: <1247488726-14960-1-git-send-email-ameya.palande@nokia.com>
I still get following warnings from checkpatch.pl:
WARNING: suspect code indent for conditional statements (0, 2)
#45: FILE: drivers/dsp/bridge/pmgr/wcd.c:151:
+do { \
+ if (DSP_SUCCEEDED(status)) { \
WARNING: suspect code indent for conditional statements (2, 4)
#46: FILE: drivers/dsp/bridge/pmgr/wcd.c:152:
+ if (DSP_SUCCEEDED(status)) { \
+ if (unlikely((src) == NULL) || \
ERROR: code indent should use tabs where possible
#49: FILE: drivers/dsp/bridge/pmgr/wcd.c:155:
+ GT_1trace(WCD_debugMask, GT_7CLASS,^I\$
WARNING: suspect code indent for conditional statements (0, 2)
#57: FILE: drivers/dsp/bridge/pmgr/wcd.c:163:
+do { \
+ if (DSP_SUCCEEDED(status)) { \
WARNING: suspect code indent for conditional statements (2, 4)
#58: FILE: drivers/dsp/bridge/pmgr/wcd.c:164:
+ if (DSP_SUCCEEDED(status)) { \
+ if (unlikely((dest) == NULL) || \
ERROR: code indent should use tabs where possible
#61: FILE: drivers/dsp/bridge/pmgr/wcd.c:167:
+ GT_1trace(WCD_debugMask, GT_7CLASS,^I\$
ERROR: code indent should use tabs where possible
#62: FILE: drivers/dsp/bridge/pmgr/wcd.c:168:
+ "copy_to_user failed, dest=0x%x\n", dest);^I\$
ERROR: code indent should use tabs where possible
#63: FILE: drivers/dsp/bridge/pmgr/wcd.c:169:
+ (status) = DSP_EPOINTER ;^I^I\$
total: 4 errors, 4 warnings, 48 lines checked
I have used 2 spaces instead of a tab for indentation so that line
won't exceed 80 columns limit, and we still maintain good amount of
readability with this macro.
Cheers,
Ameya.
next prev parent reply other threads:[~2009-07-13 12:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 15:02 [PATCH 1/4] DSPBRIDGE: Fix macros that break when inside an if/else Ameya Palande
2009-07-07 15:02 ` [PATCHv2 2/4] DSPBRIDGE: Heuristic fixes of strlen/malloc out by one Ameya Palande
2009-07-07 15:02 ` [PATCHv2 3/4] DSPBRIDGE: PROCWRAP_Load function cleanup in a complete mess Ameya Palande
2009-07-07 15:02 ` [PATCH 4/4] DSPBRIDGE: Remove unnecessary conditions from some for loops Ameya Palande
2009-07-09 23:53 ` Guzman Lugo, Fernando
2009-07-09 23:58 ` [PATCHv2 3/4] DSPBRIDGE: PROCWRAP_Load function cleanup in a complete mess Guzman Lugo, Fernando
2009-07-13 12:35 ` [PATCHv3 " Ameya Palande
2009-07-09 23:52 ` [PATCHv2 2/4] DSPBRIDGE: Heuristic fixes of strlen/malloc out by one Guzman Lugo, Fernando
2009-07-09 23:51 ` [PATCH 1/4] DSPBRIDGE: Fix macros that break when inside an if/else Guzman Lugo, Fernando
2009-07-13 12:38 ` [PATCHv2 " Ameya Palande
2009-07-13 12:42 ` Ameya Palande [this message]
2009-07-14 11:02 ` [PATCH " Phil Carmody
2009-07-14 11:05 ` Menon, Nishanth
2009-07-14 11:17 ` Ameya Palande
2009-07-14 11:20 ` Phil Carmody
2009-07-14 12:30 ` Hiroshi DOYU
2009-07-14 13:17 ` Phil Carmody
2009-07-14 20:22 ` Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5B2BA4.1090506@nokia.com \
--to=ameya.palande@nokia.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.