From: Jiri Slaby <jirislaby@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] wireless: wl12xx, fix lock imbalance
Date: Mon, 13 Jul 2009 23:44:31 +0200 [thread overview]
Message-ID: <4A5BAABF.9020708@gmail.com> (raw)
In-Reply-To: <1247521235.7178.1.camel@johannes.local>
On 07/13/2009 11:40 PM, Johannes Berg wrote:
> On Mon, 2009-07-13 at 23:24 +0200, Jiri Slaby wrote:
>> Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when
>> wl12xx_chip_wakeup fails).
>
> By the way, are you using some tool to find these?
Yup, it's called stanse[1], but we still work on that to make it stable.
> I've had local hacks
> many times to make sparse aware of mutexes, is there a reason they are
> not annotated with __acquire(s)/__release(s) like spinlocks etc.?
Mutexes are often locked/unlocked interprocedural which I think sparse
can't do much about.
[1] http://iti.fi.muni.cz/stanse/
next prev parent reply other threads:[~2009-07-13 21:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 21:24 [PATCH] wireless: wl12xx, fix lock imbalance Jiri Slaby
2009-07-13 21:40 ` Johannes Berg
2009-07-13 21:44 ` Jiri Slaby [this message]
2009-07-13 21:49 ` Jiri Slaby
2009-07-13 21:49 ` Johannes Berg
2009-07-13 21:51 ` Jiri Slaby
2009-07-13 21:54 ` Johannes Berg
2009-07-18 11:19 ` Ingo Molnar
2009-07-18 11:33 ` Johannes Berg
2009-07-18 16:10 ` Ingo Molnar
2009-07-26 8:00 ` stanse [was: wireless: wl12xx, fix lock imbalance] Jiri Slaby
2009-10-12 10:11 ` Stanse 1.0.0 released " Jiri Slaby
2009-10-12 10:11 ` Jiri Slaby
2009-10-12 10:47 ` Stanse 1.0.0 released [was: wireless: wl12xx, fix lock Ingo Molnar
2009-10-12 10:47 ` Stanse 1.0.0 released [was: wireless: wl12xx, fix lock imbalance] Ingo Molnar
2009-07-14 5:44 ` [PATCH] wireless: wl12xx, fix lock imbalance Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5BAABF.9020708@gmail.com \
--to=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.