All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Oliver Hartkopp <oliver@hartkopp.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	davem@davemloft.net, netdev@vger.kernel.org,
	urs.thuermann@volkswagen.de,
	Urs Thuermann <urs@isnogud.escape.de>
Subject: Re: use after free bug in socket code
Date: Tue, 14 Jul 2009 19:53:42 +0200	[thread overview]
Message-ID: <4A5CC626.8020800@grandegger.com> (raw)
In-Reply-To: <19036.41388.634723.358236@ipc1.ka-ro>

Lothar Waßmann wrote:
> Hi,
> 
> Oliver Hartkopp writes:
>>> The situation where this triggers a bug is when the chip driver's
>>> hard_start_xmit function returns a NETDEV_TX_BUSY and subsequently the
>>> can interface is deconfigured.
>>>
>>> Maybe you could try this on different hardware?
>> Will do when i'm back at work ;-)
>>
> Should I wait for the results of your tests before submitting the
> patches?

A user has reported sporadic kernel panics with a down/up/restart stress
test a while ago on the Socket-CAN mailing list and the patch seems to
solve his problem:

https://lists.berlios.de/pipermail/socketcan-users/2009-July/000985.html

From my point of view you can go ahead.

Thanks.

Wolfgang.

  reply	other threads:[~2009-07-14 17:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 11:26 use after free bug in socket code Lothar Waßmann
2009-07-07  2:07 ` David Miller
2009-07-07  6:59   ` Lothar Waßmann
2009-07-07 15:19     ` David Miller
2009-07-08  6:37       ` Lothar Waßmann
2009-07-09 15:45         ` Herbert Xu
2009-07-13 16:00           ` Lothar Waßmann
2009-07-13 17:46             ` Oliver Hartkopp
2009-07-13 17:54               ` David Miller
2009-07-14  6:24               ` Lothar Waßmann
2009-07-14 14:41                 ` Oliver Hartkopp
2009-07-14 15:18                   ` Lothar Waßmann
2009-07-14 17:53                     ` Wolfgang Grandegger [this message]
2009-07-15  9:10                       ` [PATCH 1/2] net/can bugfix: use after free bug in can protocol drivers Lothar Waßmann
2009-07-15  9:12                         ` [PATCH 2/2] net/can: add module alias to " Lothar Waßmann
2009-07-15 18:21                           ` David Miller
2009-07-15 18:20                         ` [PATCH 1/2] net/can bugfix: use after free bug in " David Miller
2009-07-07 12:15   ` use after free bug in socket code Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5CC626.8020800@grandegger.com \
    --to=wg@grandegger.com \
    --cc=LW@KARO-electronics.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@hartkopp.net \
    --cc=urs.thuermann@volkswagen.de \
    --cc=urs@isnogud.escape.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.