All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Yu, Ke" <ke.yu@intel.com>
Cc: "Lu, Guanqun" <guanqun.lu@intel.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct	irqaction'
Date: Tue, 14 Jul 2009 13:01:24 -0700	[thread overview]
Message-ID: <4A5CE414.3080405@goop.org> (raw)
In-Reply-To: <4D05DB80B95B23498C72C700BD6C2E0B2FAA1CB9@pdsmsx502.ccr.corp.intel.com>

On 07/13/09 01:46, Yu, Ke wrote:
> Hi Jeremy,
>
> Forget to mention, this series of patches are targeting for pv_ops dom0 host S3.
>
> We have tried the host S3 branch (xen-tip/dom0/acpi) and find host S3 will hang at disable_nonboot_cpus. the root cause is that suspend_device_irqs () unfortunately will disable the irq of XEN_CALL_FUNCTION_SINGLE_VECTOR IPI and xen_timer_interrupt VIRQ, which however are required by disable_nonboot_cpus. To fix this issue, flag IRQF_NO_SUSPEND is added to Xen IPI and IRQF_TIMER is added to xen_timer_interrupt VIRQ, to notify suspend_device_irqs not to disable these irqs when suspend.
>
> After applying this series of patches to xen-tip/dom0/acpi branch, and rebasing xen-tip/dom0/acpi to xen-tip/master, the pv_ops dom0 host S3 is working in our side.
>   

Thanks for debugging that.  Could you send me a patch?  Is the
IRQF_NO_SUSPEND flag something you've had to add?

Thanks,

    J

  reply	other threads:[~2009-07-14 20:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13  4:07 [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction' Guanqun Lu
2009-07-13  4:07 ` [PATCH 2/3] add IRQF_NO_SUSPEND for 'bind_ipi_to_irqhandler' Guanqun Lu
2009-07-13  4:08   ` [PATCH 3/3] add IRQF_TIMER to Xen timer Guanqun Lu
2009-07-13  8:46 ` [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction' Yu, Ke
2009-07-14 20:01   ` Jeremy Fitzhardinge [this message]
2009-07-15  2:10     ` Yu, Ke
     [not found] <1247834204-3084-1-git-send-email-guanqun.lu@intel.com>
2009-07-17  1:52 ` Rafael J. Wysocki
2009-07-17  2:16   ` Lu, Guanqun
2009-07-17  2:41     ` Rafael J. Wysocki
2009-07-17 14:17   ` Thomas Gleixner
2009-07-20  2:55     ` Lu, Guanqun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5CE414.3080405@goop.org \
    --to=jeremy@goop.org \
    --cc=guanqun.lu@intel.com \
    --cc=ke.yu@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.