From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction' Date: Tue, 14 Jul 2009 13:01:24 -0700 Message-ID: <4A5CE414.3080405@goop.org> References: <1247564671-3090-1-git-send-email-guanqun.lu@intel.com> <4D05DB80B95B23498C72C700BD6C2E0B2FAA1CB9@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D05DB80B95B23498C72C700BD6C2E0B2FAA1CB9@pdsmsx502.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Yu, Ke" Cc: "Lu, Guanqun" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 07/13/09 01:46, Yu, Ke wrote: > Hi Jeremy, > > Forget to mention, this series of patches are targeting for pv_ops dom0 host S3. > > We have tried the host S3 branch (xen-tip/dom0/acpi) and find host S3 will hang at disable_nonboot_cpus. the root cause is that suspend_device_irqs () unfortunately will disable the irq of XEN_CALL_FUNCTION_SINGLE_VECTOR IPI and xen_timer_interrupt VIRQ, which however are required by disable_nonboot_cpus. To fix this issue, flag IRQF_NO_SUSPEND is added to Xen IPI and IRQF_TIMER is added to xen_timer_interrupt VIRQ, to notify suspend_device_irqs not to disable these irqs when suspend. > > After applying this series of patches to xen-tip/dom0/acpi branch, and rebasing xen-tip/dom0/acpi to xen-tip/master, the pv_ops dom0 host S3 is working in our side. > Thanks for debugging that. Could you send me a patch? Is the IRQF_NO_SUSPEND flag something you've had to add? Thanks, J