From: Stefan Weil <weil@mail.berlios.de>
To: Christoph Hellwig <hch@lst.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments
Date: Tue, 14 Jul 2009 23:29:01 +0200 [thread overview]
Message-ID: <4A5CF89D.2000103@mail.berlios.de> (raw)
In-Reply-To: <20090714212449.GB7580@lst.de>
Christoph Hellwig schrieb:
> On Sat, Jul 11, 2009 at 02:35:44PM +0200, Stefan Weil wrote:
>
>> atoi won't parse sedecimal pattern values (it always returns 0).
>> The qemu-iotests use such pattern values, to strtol is needed
>> to get correct results.
>>
>
> Indeed. But now that we're using strtol which can return useful
> errors I think we should also handle those errors. Can you respin
> the patch with that error handling added?
Yes, but I'll finish the vdi driver first, so an improved patch will
have to wait a little.
I'd prefer to see the current version of the patch applied as
first step.
Regards,
Stefan
next prev parent reply other threads:[~2009-07-14 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 12:34 [Qemu-devel] [PATCH] qemu-iotests: fix pattern for write test Stefan Weil
2009-07-11 12:35 ` [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments Stefan Weil
2009-07-14 21:24 ` Christoph Hellwig
2009-07-14 21:29 ` Stefan Weil [this message]
2009-07-14 21:20 ` [Qemu-devel] [PATCH] qemu-iotests: fix pattern for write test Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5CF89D.2000103@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.