All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marko Saukko <marko.saukko@gmail.com>
To: ofono@ofono.org
Subject: Re: Problems with voice call.
Date: Wed, 15 Jul 2009 08:56:59 +0300	[thread overview]
Message-ID: <4A5D6FAB.8090500@gmail.com> (raw)
In-Reply-To: <200907141034.19444.denkenz@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

Hi Denis,

>
> I've seen this reported at least twice now.  Which means that my SMS support
> detection in atmodem driver is probably not quite correct.  Would you be able
> to report at which point in the drivers/atmodem/sms.c initialization that this
> fails?
>

With the Option iCON 225 USB modem the SMS error is sent in function
at_cmgf_query_cb() at line 795.

795                 return at_sms_not_supported(modem);

This is because the mode variable is always set to 0 at line 788
(while loop is executed only onces) and the supported stays at value FALSE:

788                 while (g_at_result_iter_next_number(&iter, &mode))
789                         if (mode == 1)
790                                 supported = TRUE;



I also tested oFono with the Nokia E51 phone which if I have understood
correctly supports of sending SMS messages at least on Windows
with PC Suite software. The result is a bit different.

With E51 the SMS error is returned from function at_cpms_query_cb()
on line 764.

764                 return at_sms_not_supported(modem);

This is because it does not go inside the while loop starting at line 741,
and the me_supported and sm_supported stays FALSE:

740
741                         while (g_at_result_iter_next_string(&iter, &store)) {
742                                 if (!strcmp(store, "ME"))
743                                         me_supported[mem] = TRUE;
744                                 else if (!strcmp(store, "SM"))
745                                         sm_supported[mem] = TRUE;
746                         }
747


Regards,
Marko

  reply	other threads:[~2009-07-15  5:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13  6:13 Problems with voice call Marko Saukko
2009-07-13  9:01 ` Li, Zhigang
2009-07-13 11:25 ` Marcel Holtmann
2009-07-13 15:47 ` Denis Kenzior
2009-07-14  5:50   ` Marko Saukko
2009-07-14  6:17     ` Marcel Holtmann
2009-07-14 15:34     ` Denis Kenzior
2009-07-15  5:56       ` Marko Saukko [this message]
2009-07-15 16:51         ` Denis Kenzior
2009-07-16  5:36           ` Marko Saukko
2009-07-16 14:47             ` Juha Korpi
2009-07-16 16:46               ` Denis Kenzior
2009-07-16 18:36                 ` Juha Korpi
2009-07-16 15:08             ` Denis Kenzior
2009-07-17  6:51               ` Marko Saukko
2009-07-17 15:48                 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5D6FAB.8090500@gmail.com \
    --to=marko.saukko@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.