From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames Date: Wed, 15 Jul 2009 18:42:17 +0200 Message-ID: <4A5E06E9.9030104@redhat.com> References: <1245862739.6278.7.camel@localhost> <1246063310.6278.115.camel@localhost> <1246511321.6429.31.camel@localhost> <4A4C754D.10109@redhat.com> <4A4CAD86.9020607@us.ibm.com> <4A4CB39F.5070506@redhat.com> <1247041831.6297.12.camel@localhost> <1247644283.14246.3.camel@localhost> <4A5DF252.50408@us.ibm.com> <4A5DF875.2020808@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Blue Swirl , kvm-devel , linuxram@us.ibm.com, qemu-devel@nongnu.org, Jan Kiszka , Paul Brook To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38249 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755198AbZGOQpc (ORCPT ); Wed, 15 Jul 2009 12:45:32 -0400 In-Reply-To: <4A5DF875.2020808@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori schrieb: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img >> > > The explicit ordering part seems clunky to me. How about: > > -drive name=vda,if=virtio -drive.vda.file filename.img > > What's nice about this syntax is it generalizes well. You could have: > > -drive.vda.if virtio -drive.vda.file filename.img > -net nic,model=rtl8139,name=foo -net.foo.macaddr 00:11:43:55:44:22 Looks like a very verbose syntax. However, it's the cleanest suggestion so far, IMHO. It might be perfectly reasonable to use for management apps or for a single option (the file name) manually as needed. We'll need to retain the old, more convenient syntax anyway for compatibility. Your examples are mixed style already, so this is probably what you intended anyway. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MR7bs-0007JR-DO for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:45:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MR7bn-0007GX-Dp for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:45:35 -0400 Received: from [199.232.76.173] (port=47673 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MR7bn-0007GS-06 for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:45:31 -0400 Received: from mx2.redhat.com ([66.187.237.31]:33763) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MR7bm-0006J6-Gn for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:45:30 -0400 Message-ID: <4A5E06E9.9030104@redhat.com> Date: Wed, 15 Jul 2009 18:42:17 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames References: <1245862739.6278.7.camel@localhost> <1246063310.6278.115.camel@localhost> <1246511321.6429.31.camel@localhost> <4A4C754D.10109@redhat.com> <4A4CAD86.9020607@us.ibm.com> <4A4CB39F.5070506@redhat.com> <1247041831.6297.12.camel@localhost> <1247644283.14246.3.camel@localhost> <4A5DF252.50408@us.ibm.com> <4A5DF875.2020808@us.ibm.com> In-Reply-To: <4A5DF875.2020808@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm-devel , linuxram@us.ibm.com, qemu-devel@nongnu.org, Blue Swirl , Jan Kiszka , Paul Brook Anthony Liguori schrieb: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img >> > > The explicit ordering part seems clunky to me. How about: > > -drive name=vda,if=virtio -drive.vda.file filename.img > > What's nice about this syntax is it generalizes well. You could have: > > -drive.vda.if virtio -drive.vda.file filename.img > -net nic,model=rtl8139,name=foo -net.foo.macaddr 00:11:43:55:44:22 Looks like a very verbose syntax. However, it's the cleanest suggestion so far, IMHO. It might be perfectly reasonable to use for management apps or for a single option (the file name) manually as needed. We'll need to retain the old, more convenient syntax anyway for compatibility. Your examples are mixed style already, so this is probably what you intended anyway. Kevin