From: Tejun Heo <tj@kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH #tj-block-for-linus] block: fix failfast merge testing in elv_rq_merge_ok()
Date: Thu, 16 Jul 2009 17:35:11 +0900 [thread overview]
Message-ID: <4A5EE63F.9050205@kernel.org> (raw)
In-Reply-To: <4A5EE2BD.8030100@panasas.com>
Boaz Harrosh wrote:
> OK So could you put a FIXME: and fat comment, on that weird "!"(s)
> everywhere?
Yeap, sure. How about something like the following?
/*
* Don't merge if failfast settings don't match. The negation
* in front of each condition is necessary because bio and
* request flags use different bit positions and the accessors
* return those bits directly. This ugliness will soon go
* away.
*/
--
tejun
next prev parent reply other threads:[~2009-07-16 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 6:44 [PATCH #tj-block-for-linus] block: fix failfast merge testing in elv_rq_merge_ok() Tejun Heo
2009-07-16 7:57 ` Boaz Harrosh
2009-07-16 8:06 ` Tejun Heo
2009-07-16 8:20 ` Boaz Harrosh
2009-07-16 8:35 ` Tejun Heo [this message]
2009-07-16 8:48 ` Boaz Harrosh
2009-07-17 5:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5EE63F.9050205@kernel.org \
--to=tj@kernel.org \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.