All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: dlaor@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] CPUID feature bits not saved with migration
Date: Thu, 16 Jul 2009 12:09:11 +0200	[thread overview]
Message-ID: <4A5EFC47.3050304@amd.com> (raw)
In-Reply-To: <4A5ECEE9.8070708@redhat.com>

Dor Laor wrote:
> On 07/15/2009 06:12 PM, Jamie Lokier wrote:
>> Anthony Liguori wrote:
>>> It's unclear what to do about -cpu host.  If we did migrate cpuid
>>> values, then -cpu would effectively be ignored after an incoming 
>>> migration.
> 
> Actually, it might be better to build all of the guest configurations 
> (devices, cpu, etc) from the migration stream, without stating them in 
> the destination command line.
> 
> The destination command line should only contain host configuration.
> It will bypass any type of conflict between the src/dst pairs.
I think there were some ideas on implementing this (transfer of guest 
configuration in a separate savevm section) in the past. Has someone 
started looking at this?

>>
>> The new host might not support all the cpuid features of the old host,
>> whether by -cpu host or explicit cpuid.  What happens then?
>>
>> For changing cpuid when migrating, as you might like to do with -cpu
>> host for performance, is reboot-during-migrate useful?  It would make
>> sure all disk state is committed to the image files asynchronously
>> while the machine continues to run (just like normal migration), and
>> at the last moment transfers control and the machine sees a reboot,
>> permitting devices changes including cpuid change.
>>
>> CPU hotplug could be used for cpuid change in theory, but I doubt if
>> any guests or guest apps would handle it well.
> 
> We should just fail migration in case the destination host cannot match 
> the source requirements (cpuid, cpu vendor type (optionally emulate 
> them), etc).
> The complexity does not worth the gain and it won't be common practice.

For items not efficiently emulate-able (like SSE4) I agree. But I would 
try to make this list as short as possible. For instance I have an idea 
on how to cope with missing host's NX/XD capability, so one does not 
need to dump this feature because there is a single incapable box in the 
migration pool.

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448 3567 12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2009-07-16 10:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 12:50 [Qemu-devel] CPUID feature bits not saved with migration Andre Przywara
2009-07-15 14:38 ` Anthony Liguori
2009-07-15 15:12   ` Jamie Lokier
2009-07-16  6:55     ` Dor Laor
2009-07-16 10:09       ` Andre Przywara [this message]
2009-07-16 14:29       ` Jamie Lokier
2009-07-16 10:08     ` Andre Przywara
2009-07-16 14:28       ` Jamie Lokier
2009-07-22 13:24         ` Andre Przywara
2009-07-22 14:46           ` Jamie Lokier
2009-07-16 10:08   ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5EFC47.3050304@amd.com \
    --to=andre.przywara@amd.com \
    --cc=dlaor@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.