All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Olaf Weber <olaf@sgi.com>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] reduce bmv_count in xfs_vn_fiemap
Date: Thu, 16 Jul 2009 09:19:42 -0500	[thread overview]
Message-ID: <4A5F36FE.4050200@sandeen.net> (raw)
In-Reply-To: <bzybpnkhp62.fsf@fransum.emea.sgi.com>

Olaf Weber wrote:
> Eric Sandeen writes:
> 
>> commit 6321e3ed2acf3ee9643cdd403e1c88605d7944ba caused
>> the full bmv_count's worth of getbmapx structures to get
>> allocated; telling it to do MAXEXTNUM was a bit insane,
>> resulting in ENOMEM.
> 
>> Chop it down to something reasonable, the caller can
>> loop over this if the file has > 64 extents.
> 
> It does seem to me that this will result in an unusal case for the
> caller, in that it will get fewer extents than fit in the provided
> buffer, yet should loop.  Do current callers know that they can hit
> this case, detect it, and loop accordingly?  Or is this just pushing
> the problem/regression to userspace?

Well, userspace just keeps calling until it gets FIEMAP_LAST in the
flags.  But yeah, I forgot that we were given the nr of user extents,
I'll send a better V2.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-07-16 14:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 19:33 [PATCH] reduce bmv_count in xfs_vn_fiemap Eric Sandeen
2009-07-16 10:56 ` Olaf Weber
2009-07-16 14:19   ` Eric Sandeen [this message]
2009-07-16 14:48   ` [PATCH V2] " Eric Sandeen
2009-07-16 15:18     ` Olaf Weber
2009-07-16 19:11     ` [PATCH V3] " Eric Sandeen
2009-07-17 11:46       ` Olaf Weber
2009-07-18 14:25       ` Christoph Hellwig
2009-07-27  2:52       ` [PATCH V4] " Eric Sandeen
2009-07-27  7:55         ` Olaf Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5F36FE.4050200@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=olaf@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.