All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Haskins <gregory.haskins@gmail.com>
To: Gregory Haskins <ghaskins@novell.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	avi@redhat.com, glommer@redhat.com, aliguori@us.ibm.com
Subject: Re: [KVM PATCH] KVM: introduce "xinterface" API for external interaction with guests
Date: Thu, 16 Jul 2009 11:31:57 -0400	[thread overview]
Message-ID: <4A5F47ED.60209@gmail.com> (raw)
In-Reply-To: <20090716153019.GA5727@merkur.ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Sam Ravnborg wrote:
>> diff --git a/arch/x86/Kbuild b/arch/x86/Kbuild
>> index ad8ec35..9f50cc3 100644
>> --- a/arch/x86/Kbuild
>> +++ b/arch/x86/Kbuild
>> @@ -1,5 +1,7 @@
>>  
>> -obj-$(CONFIG_KVM) += kvm/
>> +ifdef CONFIG_KVM
>> +obj-y += kvm/
>> +endif
>>     
>
> What was wrong with the old version?
> If this is because xinterface.o is builtin to the kernel

Bingo

>  then we should
> always visit kvm/ and use:
>
>    obj-y += kvm/
>
> unconditionally.
>
>   
Ok, easy enough.

Thanks Sam,
-Greg




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]

  reply	other threads:[~2009-07-16 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 15:19 [KVM PATCH] xinterface Gregory Haskins
2009-07-16 15:19 ` [KVM PATCH] KVM: introduce "xinterface" API for external interaction with guests Gregory Haskins
2009-07-16 15:30   ` Sam Ravnborg
2009-07-16 15:31     ` Gregory Haskins [this message]
2009-07-16 15:37   ` Anthony Liguori
2009-07-16 15:47     ` Gregory Haskins
2009-07-16 16:09       ` Anthony Liguori
2009-07-16 16:52   ` Arnd Bergmann
2009-07-16 18:22     ` Gregory Haskins
2009-07-16 18:53       ` Gregory Haskins
2009-07-16 19:38         ` Zan Lynx
2009-07-16 19:48           ` Gregory Haskins
2009-07-16 19:46       ` Arnd Bergmann
2009-07-17  0:25         ` Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5F47ED.60209@gmail.com \
    --to=gregory.haskins@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=ghaskins@novell.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.