Re: [Qemu-devel] [PATCH v3 5/5] switch -drive to QemuOpts.

[Gerd Hoffmann <kraxel@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

On 07/16/09 18:07, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> Demo QemuOpts in action ;)
>>
>> Implementing a alternative way to specify the filename should be
>> just a few lines of code now once we decided how the cmd line syntax
>> should look like.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> $ x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot
> drive: <noid>: index="0" media="disk"
> file="/home/anthony/images/linux.img" snapshot="1"
> qemu: '1' invalid snapshot option
>
> Not quite sure that's the action you were looking for...

Quick fix (incremental) attached.
Oh, and a leftover debug line ...

cheers,
   Gerd


[-- Attachment #2: fix --]
[-- Type: text/plain, Size: 714 bytes --]

diff --git a/vl.c b/vl.c
index dfdea55..7d07d69 100644
--- a/vl.c
+++ b/vl.c
@@ -2346,7 +2346,7 @@ static int drive_init_func(QemuOpts *opts, void *opaque)
     QEMUMachine *machine = opaque;
     int fatal_error = 0;
 
-    qemu_opts_print(opts, NULL);
+//    qemu_opts_print(opts, NULL);
     if (drive_init(opts, machine, &fatal_error) == NULL) {
         if (fatal_error)
             return 1;
@@ -2357,7 +2357,7 @@ static int drive_init_func(QemuOpts *opts, void *opaque)
 static int drive_enable_snapshot(QemuOpts *opts, void *opaque)
 {
     if (NULL == qemu_opt_get(opts, "snapshot")) {
-        qemu_opt_set(opts, "snapshot", "1");
+        qemu_opt_set(opts, "snapshot", "on");
     }
     return 0;
 }