All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] Fix 2k page size NAND for iMX27
Date: Fri, 17 Jul 2009 08:06:18 +0200	[thread overview]
Message-ID: <4A6014DA.2040400@eukrea.com> (raw)
In-Reply-To: <20090716195440.GH32758@b07421-ec1.am.freescale.net>

Scott Wood a ?crit :
> On Wed, Jul 15, 2009 at 05:18:40PM +0200, Eric Benard wrote:
>> +	if (pdata->is2k) {
>> +		host->pagesize_2k = 1;
>> +		NFMS |= (1 << NFMS_BIT);
>> +		this->badblock_pattern = &smallpage_memorybased;
> 
> Why are you using the small-page badblock pattern with large pages?
> 
that's what Freescale is doing in its Linux BSP and it doesn't work 
without, at least on my board (8 bits width NAND):

	if (!this->badblock_pattern) {
		if (mtd->writesize == NAND_PAGESIZE_2KB)
			this->badblock_pattern = &smallpage_memorybased;
		else
			this->badblock_pattern = (mtd->writesize > 512) ?
			    &largepage_memorybased : &smallpage_memorybased;
	}

Eric

  reply	other threads:[~2009-07-17  6:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 15:18 [U-Boot] [PATCH v2 1/3] Add Eukrea CPUIMX27 support Eric Benard
2009-07-15 15:18 ` [U-Boot] [PATCH v2 2/3] Fix 2k page size NAND for iMX27 Eric Benard
2009-07-15 15:18   ` [U-Boot] [PATCH v2 3/3] Add NAND to EUKREA CPUIMX27 defconfig Eric Benard
2009-07-16 19:54   ` [U-Boot] [PATCH v2 2/3] Fix 2k page size NAND for iMX27 Scott Wood
2009-07-17  6:06     ` Eric Bénard [this message]
2009-07-31 22:23   ` Scott Wood
2009-08-01  6:28     ` Eric Bénard
2009-08-03 15:38       ` Scott Wood
2009-07-16  7:48 ` [U-Boot] [PATCH v2 1/3] Add Eukrea CPUIMX27 support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6014DA.2040400@eukrea.com \
    --to=eric@eukrea.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.