From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx27: rename fec_imx27 to fec_mxc
Date: Fri, 17 Jul 2009 19:23:26 +0400 [thread overview]
Message-ID: <4A60976E.9000100@emcraft.com> (raw)
In-Reply-To: <20090717150806.A30D5832E416@gemini.denx.de>
Hi Wolfgang,
Wolfgang Denk wrote:
>> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>> ---
>> cpu/arm926ejs/mx27/generic.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cpu/arm926ejs/mx27/generic.c b/cpu/arm926ejs/mx27/generic.c
>> index b377fad..cbb6c85 100644
>> --- a/cpu/arm926ejs/mx27/generic.c
>> +++ b/cpu/arm926ejs/mx27/generic.c
>> @@ -165,7 +165,7 @@ int print_cpuinfo (void)
>>
>> int cpu_eth_init(bd_t *bis)
>> {
>> -#if defined(CONFIG_FEC_IMX27)
>> +#if defined(CONFIG_FEC_MXC)
>> return fecimx27_initialize(bis);
>>
>
> See Ben's comment - renaming the CONFIG_ variable but leaving
> fecimx27_initialize() makes no sense.
>
Yes. That's my fault. I'll fix this and repost the patches.
> And this should be no separate patch, but squashed into the patch
> that adds the cpu_eth_init() code.
>
Surely. I'll fix this too.
Regards, Ilya.
prev parent reply other threads:[~2009-07-17 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 11:01 [U-Boot] [PATCH] mx27: rename fec_imx27 to fec_mxc Ilya Yanok
2009-07-17 15:08 ` Wolfgang Denk
2009-07-17 15:23 ` Ilya Yanok [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A60976E.9000100@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.