From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Jenkins Subject: Re: "floppy: fix hibernation" causes error on resume from ram Date: Sat, 18 Jul 2009 19:27:34 +0100 Message-ID: <4A621416.2060609@tuffmail.co.uk> References: <4A620F3E.8080900@tuffmail.co.uk> <200907182019.57909.linux@rainbow-software.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=EXgz8VbV3vMQS+I8fbu7mJlNIcGP4wZc2jMuYZEbb+I=; b=Ci6shn0qBM68EpMqrFaHYfXyQnwvhdHm1HfrfmQk6CG0phffr0MpRqOc50A6e7Uldt MWawktbxkFHYYgJuvaF4J9rXWkMK0SugZ0FDeIwLGZge7hmXWYlI5+oILvaAPXCHIFbI Zu45Ao4VrfxLtG2CCTpL4EjYY/Rr6L6Sq5hr4= In-Reply-To: <200907182019.57909.linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Ondrej Zary Cc: Ingo Molnar , Pavel Machek , Jens Axboe , linux-kernel , Kernel Testers List Ondrej Zary wrote: > On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote: > >> Thanks for the hibernation fix! Until recently I thought my floppy was >> just dead. Unfortunately, the fix seems to cause me errors on resume >> from suspend to ram. The floppy works fine afterwards, it just spams >> the log. >> >> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram. >> So I guess the quick fix would be to only do the fix-up on resume from >> hibernation, and not suspend-to-ram. >> > > My machine has no suspend-to-RAM so I haven't tested it. > > That would be probably the correct fix. But how to do it? AFAIK, there's only > one suspend() and one resume() for everything. And that looks very wrong as > resume-from-hibernation is fundamentally different from resume-from-RAM. > Ok. Looking at drivers/base/platform.c, we want "restore()". I guess I can do the patch myself :-). Thanks Alan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbZGRS1l (ORCPT ); Sat, 18 Jul 2009 14:27:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751674AbZGRS1j (ORCPT ); Sat, 18 Jul 2009 14:27:39 -0400 Received: from mail-ew0-f226.google.com ([209.85.219.226]:58052 "EHLO mail-ew0-f226.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbZGRS1i (ORCPT ); Sat, 18 Jul 2009 14:27:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=xEKa3ATD1UWEjUF2UGdQKciElcqnZyetlJgOZFmo/6AbTYlkEVeVoQFBni1Ugfv6Qn GIumF6wzSU4OLmEmXbhFOQ+vHwVLfsPUNcwqlKG+Ft0kQyHiH/SBQMIgLFcKpHSEvy8Z mVzuk/OSAju/zytyqa/QaxrOc7dMdQQZwZ5Fs= Message-ID: <4A621416.2060609@tuffmail.co.uk> Date: Sat, 18 Jul 2009 19:27:34 +0100 From: Alan Jenkins User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: Ondrej Zary CC: Ingo Molnar , Pavel Machek , Jens Axboe , linux-kernel , Kernel Testers List Subject: Re: "floppy: fix hibernation" causes error on resume from ram References: <4A620F3E.8080900@tuffmail.co.uk> <200907182019.57909.linux@rainbow-software.org> In-Reply-To: <200907182019.57909.linux@rainbow-software.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ondrej Zary wrote: > On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote: > >> Thanks for the hibernation fix! Until recently I thought my floppy was >> just dead. Unfortunately, the fix seems to cause me errors on resume >> from suspend to ram. The floppy works fine afterwards, it just spams >> the log. >> >> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram. >> So I guess the quick fix would be to only do the fix-up on resume from >> hibernation, and not suspend-to-ram. >> > > My machine has no suspend-to-RAM so I haven't tested it. > > That would be probably the correct fix. But how to do it? AFAIK, there's only > one suspend() and one resume() for everything. And that looks very wrong as > resume-from-hibernation is fundamentally different from resume-from-RAM. > Ok. Looking at drivers/base/platform.c, we want "restore()". I guess I can do the patch myself :-). Thanks Alan