All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Christopher Li <sparse@chrisli.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Junio C Hamano <gitster@pobox.com>, Andreas Ericsson <ae@op5.se>,
	Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: Multiple translation unit regression
Date: Sat, 18 Jul 2009 21:26:23 +0100	[thread overview]
Message-ID: <4A622FEF.2010704@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4A5B7257.9090409@ramsay1.demon.co.uk>

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

Ramsay Jones wrote:
> Christopher Li wrote:
>> I attach the patch follows. Can you give it a try?
>>
> 
> Yep, this works.
> Tested on cygwin and Linux.
> 
> Thanks!
> 

BTW, I forgot to mention that I changed the test file so that
it would fail before applying the rest of this patch, and
pass afterward.

I've attached the new file. The diff is as follows:

-->8--
diff --git a/validation/extern-inline.c b/validation/extern-inline.c
index 13af438..4f12ac0 100644
--- a/validation/extern-inline.c
+++ b/validation/extern-inline.c
@@ -17,6 +17,7 @@ g(int x)
 
 /*
  * check-name: extern inline function
+ * check-command: sparse $file $file
  * check-description: Extern inline function never emits stand alone copy
  * of the function. It allows multiple such definitions in different file.
  */
-->8--

HTH.

ATB,
Ramsay Jones


[-- Attachment #2: extern-inline.c --]
[-- Type: text/plain, Size: 391 bytes --]

extern __inline__ int f(int);

extern __inline__ int
f(int x)
{
        return x;
}

extern int g(int);

extern __inline__ int
g(int x)
{
        return x;
}


/*
 * check-name: extern inline function
 * check-command: sparse $file $file
 * check-description: Extern inline function never emits stand alone copy
 * of the function. It allows multiple such definitions in different file.
 */

  reply	other threads:[~2009-07-18 21:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-05 23:06 Multiple translation unit regression Ramsay Jones
2009-07-06  9:32 ` Christopher Li
2009-07-07  6:27   ` Christopher Li
2009-07-08 19:32     ` Ramsay Jones
2009-07-08 20:15       ` Christopher Li
2009-07-10 20:53         ` Ramsay Jones
2009-07-10 23:27           ` Christopher Li
2009-07-13 17:43             ` Ramsay Jones
2009-07-18 20:26               ` Ramsay Jones [this message]
2009-07-18 21:53                 ` Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A622FEF.2010704@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1.demon.co.uk \
    --cc=ae@op5.se \
    --cc=gitster@pobox.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.