From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Tao Subject: Re: [PATCH 5/5] Makefile.in: allow make install e4defrag Date: Mon, 20 Jul 2009 12:21:05 +0800 Message-ID: <4A63F0B1.7090002@gmail.com> References: <1248025714-25954-1-git-send-email-bergwolf@gmail.com> <4A639228.9090905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org, tytso@mit.edu To: Eric Sandeen Return-path: Received: from mail-px0-f193.google.com ([209.85.216.193]:58289 "EHLO mail-px0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbZGTEVK (ORCPT ); Mon, 20 Jul 2009 00:21:10 -0400 Received: by pxi31 with SMTP id 31so200294pxi.33 for ; Sun, 19 Jul 2009 21:21:09 -0700 (PDT) In-Reply-To: <4A639228.9090905@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi, Eric Eric Sandeen wrote: > Peng Tao wrote: >> Current Makefile does not install e4defrag nor e4defrag.8. >> Change misc/Makefile.in to make the e4defrag available for use. >> >> Signed-off-by: Peng Tao > > Since this is all still fairly developmental at this point (I think?) > perhaps a special "make install-e4defrag" target might be best. > > Otherwise packages which "make install" will start shipping e4defrag, > and I'm not sure we want to do that quite yet. Thanks for your reviewing. Does the following patch meet your expectation? >>From 248322ee72e371dcd1b302400d787f9f2eec15cd Mon Sep 17 00:00:00 2001 From: Peng Tao Date: Mon, 20 Jul 2009 12:01:55 +0800 Subject: [PATCH-e2fsprogs] Makefile.in: add install-e4defrag target The e4defrag program is still developmental, but we can make it available for use if someone wants to test it. Signed-off-by: Peng Tao --- Makefile.in | 3 +++ misc/Makefile.in | 6 +++++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/Makefile.in b/Makefile.in index 45f2972..1c2b44e 100644 --- a/Makefile.in +++ b/Makefile.in @@ -57,6 +57,9 @@ clean-doc: distclean-doc: -test -d doc && cd doc && $(MAKE) distclean +install-e4defrag: subs all-libs-recursive + $(MAKE) -C misc install-e4defrag + install: subs all-libs-recursive install-progs-recursive \ install-shlibs-libs-recursive install-doc-libs if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d ext2ed ; then $(MAKE) install-libs ; fi diff --git a/misc/Makefile.in b/misc/Makefile.in index 5f5dab5..029a201 100644 --- a/misc/Makefile.in +++ b/misc/Makefile.in @@ -399,6 +399,10 @@ installdirs: $(DESTDIR)$(man1dir) $(DESTDIR)$(man5dir) \ $(DESTDIR)$(libdir) $(DESTDIR)/$(root_sysconfdir) +install-e4defrag: e4defrag e4defrag.8 installdirs + $(INSTALL_PROGRAM) e4defrag $(DESTDIR)$(bindir)/e4defrag + $(INSTALL_DATA) e4defrag.8 $(DESTDIR)$(man8dir)/e4defrag.8 + install: all $(SMANPAGES) $(UMANPAGES) installdirs $(Q) for i in $(SPROGS); do \ echo " INSTALL $(root_sbindir)/$$i"; \ @@ -556,7 +560,7 @@ clean: blkid.profiled tune2fs.profiled e2image.profiled \ e2undo.profiled mke2fs.profiled dumpe2fs.profiled \ logsave.profiled filefrag.profiled uuidgen.profiled \ - uuidd.profiled e2image.profiled \ + uuidd.profiled e2image.profiled e4defrag \ profiled/*.o \#* *.s *.o *.a *~ core gmon.out mostlyclean: clean -- 1.6.2-rc2.GIT -- Best Regards, Peng Tao State Key Laboratory of Networking and Switching Technology Beijing Univ. of Posts and Telecoms.