From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSsFx-0004AC-Nf for qemu-devel@nongnu.org; Mon, 20 Jul 2009 08:46:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSsFt-00048Z-7I for qemu-devel@nongnu.org; Mon, 20 Jul 2009 08:46:13 -0400 Received: from [199.232.76.173] (port=40986 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSsFs-00048L-Tu for qemu-devel@nongnu.org; Mon, 20 Jul 2009 08:46:08 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54347) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MSsFs-0004tH-Fg for qemu-devel@nongnu.org; Mon, 20 Jul 2009 08:46:08 -0400 Message-ID: <4A6466C7.9020505@redhat.com> Date: Mon, 20 Jul 2009 14:44:55 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1248091723-5934-1-git-send-email-kwolf@redhat.com> <20090720124033.GC9199@lst.de> In-Reply-To: <20090720124033.GC9199@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] qemu-iotests: Test bdrv_load/save_vmstate List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Christoph Hellwig schrieb: > On Mon, Jul 20, 2009 at 02:08:41PM +0200, Kevin Wolf wrote: >> This tests reading and writing in the VM state area of an image. >> To be applied on top of the test case 021 patch. > > Thanks, I've put these two in. Any chance you could send an incremental > patch that expains why the two magic offsets are choosen? Hm, actually I think there is no reason any more. It used to be some offset after the end of the image (for bdrv_put_buffer), but now that the VM state has its own offsets starting at 0, it could just be the usual 0 and 4G. Kevin