From: Shan Wei <shanwei@cn.fujitsu.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
Netdev <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH] TCP: Add comments to (near) all functions in tcp_output.c v2
Date: Mon, 20 Jul 2009 20:46:58 +0800 [thread overview]
Message-ID: <4A646742.90200@cn.fujitsu.com> (raw)
In-Reply-To: <20090720123404.GA16072@basil.fritz.box>
Andi Kleen said:
> On Mon, Jul 20, 2009 at 08:06:53PM +0800, Shan Wei wrote:
>> Andi Kleen said:
>>>
>>> +/* Compute TCP options for ESTABLISHED sockets. This is not the
>>> + * final wire format yet.
>>> + */
>> typo, “network wire”?
>
> I don't see a typo.
Just see the comment about tcp_syn_options().
"wire" vs "network wire".
>
>>
>>> +/* Test if sending is allowed right now.
>>> + */
>>> int tcp_may_send_now(struct sock *sk)
>> Is it better to provide the condition be allowed?
>
> Such a introductionary comment is not intended to be a full
> representation of the code, just a overview.
>
OK
next prev parent reply other threads:[~2009-07-20 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 20:40 [PATCH] TCP: Add comments to (near) all functions in tcp_output.c Andi Kleen
2009-07-18 6:38 ` Ilpo Järvinen
2009-07-18 10:31 ` [PATCH] TCP: Add comments to (near) all functions in tcp_output.c v2 Andi Kleen
2009-07-20 12:06 ` Shan Wei
2009-07-20 12:34 ` Andi Kleen
2009-07-20 12:46 ` Shan Wei [this message]
2009-07-20 14:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A646742.90200@cn.fujitsu.com \
--to=shanwei@cn.fujitsu.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.