All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: event tracing, ringbuffer and RB_MAX_SMALL_DATA
Date: Tue, 21 Jul 2009 09:30:21 +0800	[thread overview]
Message-ID: <4A651A2D.1020804@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0907202124490.11494@gandalf.stny.rr.com>

Steven Rostedt wrote:
> On Thu, 16 Jul 2009, Li Zefan wrote:
> 
>> Johannes Berg wrote:
>>> On Wed, 2009-07-15 at 09:08 +0800, Li Zefan wrote:
>>>
>>>> Right, the length of a dynamic array is not recorded, and this
>>>> causes 2 problems:
>>>>
>>>> - the event filter is not working properly for dynamic strings
>>>> - userspace parsers can't figure out the length of those arrays
>>>>
>>>> I had an idea some time ago, and hopefully will send out a
>>>> patch today or tomorrow. 
>>> Well except for the corner case I pointed out, you can determine the
>>> length of dynamic arrays by either
>>>  - the next dynamic array's offset or
>>>  - the length of the item.
>>>
>>> So, afaict, the simplest solution would be to not embed the length of
>>> the item in type_len if it's not divisible by four and contains dynamic
>>> members, though the latter condition might be hard to check.
>>>
>> Actually I'm going to encode the size of a dynamic array
>> in it's @offset, so the lower 16bits is offset and the
>> higher 16bits is size.
> 
> Was there a patch sent out to do this yet, or is this still something 
> being worked on?
> 

Haven't you pulled it as you said. ;)

http://lkml.org/lkml/2009/7/20/155


  reply	other threads:[~2009-07-21  1:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 17:18 event tracing, ringbuffer and RB_MAX_SMALL_DATA Johannes Berg
2009-07-15  1:08 ` Li Zefan
2009-07-15  9:48   ` Johannes Berg
2009-07-16  0:48     ` Li Zefan
2009-07-21  1:25       ` Steven Rostedt
2009-07-21  1:30         ` Li Zefan [this message]
2009-07-21  1:42           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A651A2D.1020804@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.