All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lukáš Doktor" <ldoktor@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: KVM list <kvm@vger.kernel.org>,
	Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [KVM_AUTOTEST] set English environment
Date: Tue, 21 Jul 2009 07:55:13 +0200	[thread overview]
Message-ID: <4A655841.9040500@redhat.com> (raw)
In-Reply-To: <200907210209.00154.arnd@arndb.de>

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Dne 21.7.2009 02:09, Arnd Bergmann napsal(a):
> On Thursday 09 July 2009, Lukáš Doktor wrote:
>>    --- orig/client/tests/kvm/control       2009-07-08 13:18:07.000000000 +0200
>> +++ new/client/tests/kvm/control        2009-07-09 12:32:32.000000000 +0200
>> @@ -45,6 +45,8 @@ Each test is appropriately documented on
>>
>>   import sys, os
>>
>> +# set English environment
>> +os.environ['LANG'] = 'en_US.UTF-8'
>>   # enable modules import from current directory (tests/kvm)
>>   pwd = os.path.join(os.environ['AUTODIR'],'tests/kvm')
>>   sys.path.append(pwd)
>
> LANG can still be overridden with LC_ALL. For a well-defined environment,
> best set LC_ALL='C'. This will also set other i18n settings and works
> on systems that don't come with UTF-8 enabled.
>
> 	Arnd<><

Yes, you are right. LC_ALL='C' is more clean way to do.

Attached the fixed patch.

[-- Attachment #2: language.patch --]
[-- Type: text/plain, Size: 410 bytes --]

--- orig/client/tests/kvm/control	2009-07-08 13:18:07.000000000 +0200
+++ new/client/tests/kvm/control	2009-07-09 12:32:32.000000000 +0200
@@ -45,6 +45,8 @@ Each test is appropriately documented on
 
 import sys, os
 
+# set English environment
+os.environ['LC_ALL'] = 'C'
 # enable modules import from current directory (tests/kvm)
 pwd = os.path.join(os.environ['AUTODIR'],'tests/kvm')
 sys.path.append(pwd)

      reply	other threads:[~2009-07-21  5:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 10:50 [KVM_AUTOTEST] set English environment Lukáš Doktor
2009-07-20 13:16 ` Lucas Meneghel Rodrigues
2009-07-21  0:09 ` Arnd Bergmann
2009-07-21  5:55   ` Lukáš Doktor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A655841.9040500@redhat.com \
    --to=ldoktor@redhat.com \
    --cc=arnd@arndb.de \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.