Re: [Qemu-devel] [PATCH] qemu-io: Rework alloc command

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

Christoph Hellwig schrieb:
> On Mon, Jul 20, 2009 at 04:48:43PM +0200, Kevin Wolf wrote:
>> The alloc command in qemu-io is mostly useless currently. Instead of doing a
>> single call to bdrv_is_allocated, we must call bdrv_is_allocated in a loop
>> until we have found out for each requested sector if it is allocated or not
>> (bdrv_is_allocated returns a number of sectors that are known to be in the same
>> state as the first one, but it is not required to include all of them)
>>
>> This changes the output format of the alloc command so that a change to the
>> expected output of qemu-iotests 019 is necessary once this is included.
> 
> Looks good to me.  Can you post the corresponding qemu-iotests patch,
> too?

I wanted to post it when the qemu-io change is in, but if you want to
apply it earlier (makes qcow2 and vmdk fail until the qemu-io patch is
committed), here is it.

Kevin

[-- Attachment #2: 0001-qemu-iotests-Fix-expected-result-for-019-after-qemu.patch --]
[-- Type: text/plain, Size: 969 bytes --]

>From 41f80a74b4177e5396dab7916f8f7b40a65cef07 Mon Sep 17 00:00:00 2001
From: Kevin Wolf <kwolf@redhat.com>
Date: Tue, 21 Jul 2009 09:16:37 +0200
Subject: [PATCH] qemu-iotests: Fix expected result for 019 after qemu-io change

The output of the alloc command in qemu-io has changed.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 019.out |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/019.out b/019.out
index f461f8b..9ac1a21 100644
--- a/019.out
+++ b/019.out
@@ -539,8 +539,8 @@ qemu-io> wrote 65536/65536 bytes at offset 4296146944
 qemu-io> No errors were found on the image.
 Checking if backing clusters are allocated when they shouldn't
 
-qemu-io> 128/128 sectors not allocated at offset 1 MiB
-qemu-io> qemu-io> 128/128 sectors not allocated at offset 4.001 GiB
+qemu-io> 0/128 sectors allocated at offset 1 MiB
+qemu-io> qemu-io> 0/128 sectors allocated at offset 4.001 GiB
 qemu-io> Reading
 
 === IO: pattern 0
-- 
1.6.0.6