[Qemu-devel] Re: [PATCH] update server bits on vnc_update

[Gerd Hoffmann <kraxel@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

On 07/21/09 10:09, Gerd Hoffmann wrote:
> On 07/18/09 06:47, Glauber Costa wrote:
> And while looking at the code I think I've spotted the actual bug: When
> sending a bitblit to the client we do *not* update the local server
> surface. Result is the vnc clients and the vnc servers idea of the
> screen content are not in sync any more. Which in turn will break the
> optimization in (2) and can easily result in a corrupted screen ...

Quick test:  Disabling copyrect should make the screen corruption go 
away then.  Real fix will follow later.

cheers,
   Gerd

[-- Attachment #2: fix --]
[-- Type: text/plain, Size: 529 bytes --]

diff --git a/vnc.c b/vnc.c
index de0ff87..86acfee 100644
--- a/vnc.c
+++ b/vnc.c
@@ -1541,9 +1541,11 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings)
         case VNC_ENCODING_RAW:
             vs->vnc_encoding = enc;
             break;
+#if 0
         case VNC_ENCODING_COPYRECT:
             vs->features |= VNC_FEATURE_COPYRECT_MASK;
             break;
+#endif
         case VNC_ENCODING_HEXTILE:
             vs->features |= VNC_FEATURE_HEXTILE_MASK;
             vs->vnc_encoding = enc;