From: Michal Simek <michal.simek@petalogix.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Fix to set the signal handler of SIGINT in mq_timedreceive01
Date: Tue, 21 Jul 2009 15:07:33 +0200 [thread overview]
Message-ID: <4A65BD95.7070001@petalogix.com> (raw)
In-Reply-To: <4A6527B6.7070602@cn.fujitsu.com>
Hi,
Please fix coding style violation.
Use tab instead of spaces.
Subrata should reject this patch with bad coding style.
Can you please fix it?
Thanks,
Michal
> The test case mq_timedreceive01 does not register the signal
> handler of SIGINT, so the problam will be terminated by SIGINT
> from child process.
>
> This patch fixed the problem.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> diff --git a/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c b/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> index dadc38d..beeb298 100644
> --- a/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> +++ b/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> @@ -106,6 +106,14 @@ extern void cleanup() {
> tst_exit();
> }
>
> +/*
> + * sighandler()
> + */
> +void sighandler(int sig)
> +{
> + return;
> +}
> +
> /* Local Functions */
> /******************************************************************************/
> /* */
> @@ -126,6 +134,7 @@ extern void cleanup() {
> /******************************************************************************/
> void setup() {
> /* Capture signals if any */
> + signal(SIGINT, sighandler);
> /* Create temporary directories */
> TEST_PAUSE;
> tst_tmpdir();
> @@ -432,17 +441,6 @@ EXIT:
> return result;
> }
>
> -/*
> - * sighandler()
> - */
> -void sighandler(int sig)
> -{
> - if (sig == SIGINT)
> - return;
> - // NOTREACHED
> - return;
> -}
> -
>
>
> /*
>
>
>
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2009-07-21 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 2:28 [LTP] [PATCH] Fix to set the signal handler of SIGINT in mq_timedreceive01 Wei Yongjun
2009-07-21 13:07 ` Michal Simek [this message]
2009-07-22 5:47 ` Wei Yongjun
2009-07-30 18:29 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A65BD95.7070001@petalogix.com \
--to=michal.simek@petalogix.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.